Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[share] Specify explicit type for invokeMethod & const for Rect #1881

Merged
merged 4 commits into from
Jul 21, 2019
Merged

[share] Specify explicit type for invokeMethod & const for Rect #1881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e5941c6
explicit type for invokeMethod
creativecreatorormaybenot Jul 19, 2019
c07536c
fix tests + const Rect
creativecreatorormaybenot Jul 19, 2019
b0f300a
Update pubspec.yaml
collinjackson Jul 20, 2019
84bc178
Update CHANGELOG.md
collinjackson Jul 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/share/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 0.6.2+1

* Specify explicit type for `invokeMethod`.
* Use `const` for `Rect`.
* Updated minimum Flutter SDK to 1.6.0.

## 0.6.2

* Add optional subject to fill email subject in case user selects email app.
Expand Down
5 changes: 1 addition & 4 deletions packages/share/lib/share.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ class Share {
params['originHeight'] = sharePositionOrigin.height;
}

// TODO(amirh): remove this on when the invokeMethod update makes it to stable Flutter.
// https://github.com/flutter/flutter/issues/26431
// ignore: strong_mode_implicit_dynamic_method
return channel.invokeMethod('share', params);
return channel.invokeMethod<void>('share', params);
}
}
4 changes: 2 additions & 2 deletions packages/share/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Flutter plugin for sharing content via the platform share UI, using
the ACTION_SEND intent on Android and UIActivityViewController on iOS.
author: Flutter Team <flutter-dev@googlegroups.com>
homepage: https://github.com/flutter/plugins/tree/master/packages/share
version: 0.6.2
version: 0.6.2+1

flutter:
plugin:
Expand All @@ -24,4 +24,4 @@ dev_dependencies:

environment:
sdk: ">=2.0.0-dev.28.0 <3.0.0"
flutter: ">=0.1.4 <2.0.0"
flutter: ">=1.6.0 <2.0.0"
15 changes: 4 additions & 11 deletions packages/share/test/share_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,8 @@ void main() {
mockChannel = MockMethodChannel();
// Re-pipe to mockito for easier verifies.
Share.channel.setMockMethodCallHandler((MethodCall call) async {
// TODO(amirh): remove this on when the invokeMethod update makes it to stable Flutter.
// https://github.com/flutter/flutter/issues/26431
// ignore: strong_mode_implicit_dynamic_method
mockChannel.invokeMethod(call.method, call.arguments);
// The explicit type can be void as the only method call has a return type of void.
mockChannel.invokeMethod<void>(call.method, call.arguments);
});
});

Expand All @@ -44,14 +42,9 @@ void main() {
await Share.share(
'some text to share',
subject: 'some subject to share',
// TODO(jackson): Use const Rect when available in minimum Flutter SDK
// ignore: prefer_const_constructors
sharePositionOrigin: Rect.fromLTWH(1.0, 2.0, 3.0, 4.0),
sharePositionOrigin: const Rect.fromLTWH(1.0, 2.0, 3.0, 4.0),
);
// TODO(amirh): remove this on when the invokeMethod update makes it to stable Flutter.
// https://github.com/flutter/flutter/issues/26431
// ignore: strong_mode_implicit_dynamic_method
verify(mockChannel.invokeMethod('share', <String, dynamic>{
verify(mockChannel.invokeMethod<void>('share', <String, dynamic>{
'text': 'some text to share',
'subject': 'some subject to share',
'originX': 1.0,
Expand Down