-
Couldn't load subscription status.
- Fork 3.4k
feat: migrate dartpad injection to jaspr #12559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @schultek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors how DartPad examples are embedded and displayed on the site. By transitioning to a Jaspr-native component-based solution, it aims to improve the integration, maintainability, and potentially the performance of DartPad instances, moving away from a custom JavaScript injection method. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a great improvement, migrating the DartPad injection logic from a JavaScript-based solution to a pure Jaspr implementation. The new code is well-structured, using modern Dart features like records and extension types for JS interop, and correctly separates server-side and client-side logic. The removal of the old JS file and the cleanup in the markdown files are all consistent with this migration.
I've found one potential regression where the runAutomatically option for DartPads seems to have been dropped. I've left a specific comment with a suggestion to fix it. Other than that, the changes look excellent.
|
Visit the preview URL for this PR (updated for commit 1448e24): https://flutter-docs-prod--pr12559-feat-migrate-injected-dartp-5hje0crv.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying this here as well!
Migrate dartpad injection to Jaspr.
Part of #12548
Presubmit checklist
of 80 characters or fewer.