Skip to content

Conversation

@huanghui1998hhh
Copy link
Contributor

@huanghui1998hhh huanghui1998hhh commented Oct 22, 2025

GoRouter v17 BC document.
About flutter/packages#9436

@huanghui1998hhh huanghui1998hhh requested review from a team and sfshaza2 as code owners October 22, 2025 07:59
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @huanghui1998hhh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the firebase.json configuration to include a new permanent redirect. The purpose of this change is to ensure that users seeking information on GoRouter v17 breaking changes are automatically directed to the most current and relevant documentation, improving user experience and maintaining accurate link integrity.

Highlights

  • GoRouter v17 Breaking Changes Documentation: A new 301 redirect has been added to firebase.json to point to the GoRouter v17 breaking changes document. This ensures that users accessing the /go/go-router-v17-breaking-changes path are correctly redirected to the updated Google Docs document.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a redirect for the GoRouter v17 breaking changes document. The change is functionally correct. However, I've noted a maintainability issue regarding the sorting of redirects in firebase.json. The go-router-v... entries are sorted lexicographically, not numerically, which can make finding specific versions difficult. I've left a comment suggesting this be addressed in a follow-up to improve file organization.

@parlough parlough changed the title Update firebase.json Add /go/go-router-v17-breaking-changes redirect to firebase.json Oct 22, 2025
@parlough parlough requested a review from chunhtai October 22, 2025 09:43
@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 8db46cf):

https://flutter-docs-prod--pr12584-main-f0a1atqo.web.app

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redirect looks good to me, thanks!

@parlough parlough merged commit be4f980 into flutter:main Oct 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants