-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Include page title and description in md output #12639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @parlough, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the site's content generation by ensuring that page titles and descriptions are automatically included in the secondary Markdown output, improving the readability and context of generated documentation. It also includes a minor refactoring of a core component and updates various package dependencies to maintain compatibility and leverage the latest features and fixes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates dependencies and adds a feature to include the page title and description in the secondary Markdown output. The implementation for adding the header is mostly correct, but I've suggested a small improvement to make it more robust by handling cases where a page might have a description but no title. The other changes are dependency updates which look fine.
|
Visit the preview URL for this PR (updated for commit e8c999e): https://flutter-docs-prod--pr12639-feat-header-in-markdown-out-0w19b91b.web.app |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Includes the page title and description (if present) in the secondary Markdown output for each page.
Staged example: https://flutter-docs-prod--pr12639-feat-header-in-markdown-out-0w19b91b.web.app/ui/layout/tutorial/index.html.md