-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add glossary tooltip #12654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add glossary tooltip #12654
Conversation
Summary of ChangesHello @schultek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates a new glossary tooltip feature across the site, aiming to provide users with immediate context for technical terms without navigating away. The implementation involves adding new CSS for styling, Dart client-side logic for interactive behavior (such as showing/hiding on hover/click and dynamic positioning), and a server-side content processor to automatically convert glossary links into interactive tooltip components. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a glossary tooltip feature, enhancing user experience by providing quick definitions. The implementation is well-done, spanning SCSS, client-side Dart, and a server-side Jaspr extension. The code is clean and effective. I have a couple of suggestions for global_scripts.dart to enhance code robustness and conciseness.
|
Visit the preview URL for this PR (updated for commit 32b144a): https://flutter-docs-prod--pr12654-feat-glossary-tooltip-xhqnklmd.web.app |
251f22b to
32b144a
Compare
parlough
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for migrating this over! Looks great to me :D
This copies over the Glossary Tooltips that have also been added to `dart-lang/site-www` in dart-lang/site-www#6969. Adds two example uses for "widget" [here](https://flutter-docs-prod--pr12654-feat-glossary-tooltip-xhqnklmd.web.app/) and [here](https://flutter-docs-prod--pr12654-feat-glossary-tooltip-xhqnklmd.web.app/app-architecture/concepts#separation-of-concerns).
This copies over the Glossary Tooltips that have also been added to
dart-lang/site-wwwin dart-lang/site-www#6969.Adds two example uses for "widget" here and here.