Skip to content

Conversation

@schultek
Copy link
Contributor

@schultek schultek commented Nov 6, 2025

This copies over the Glossary Tooltips that have also been added to dart-lang/site-www in dart-lang/site-www#6969.

Adds two example uses for "widget" here and here.

@schultek schultek requested a review from parlough November 6, 2025 10:54
@schultek schultek requested review from a team and sfshaza2 as code owners November 6, 2025 10:54
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @schultek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a new glossary tooltip feature across the site, aiming to provide users with immediate context for technical terms without navigating away. The implementation involves adding new CSS for styling, Dart client-side logic for interactive behavior (such as showing/hiding on hover/click and dynamic positioning), and a server-side content processor to automatically convert glossary links into interactive tooltip components.

Highlights

  • New Glossary Tooltip Feature: Introduces interactive tooltips for glossary terms, enhancing user experience by providing quick definitions directly on the page.
  • Styling and Responsiveness: Adds dedicated SCSS for tooltip appearance and ensures responsive behavior for both touch and non-touch devices, adapting interaction methods accordingly.
  • Client-side Logic: Implements Dart code to manage tooltip visibility, dynamic positioning to prevent overflow, and interaction, including click-to-toggle on touchscreens and auto-closing when clicking outside.
  • Content Processing Integration: A new GlossaryLinkProcessor automatically identifies and transforms existing glossary links within the content into interactive tooltip elements during page rendering.
  • Example Usage: Updates two content files (concepts.md and index.md) to demonstrate the new tooltip functionality for the term "widget".
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a glossary tooltip feature, enhancing user experience by providing quick definitions. The implementation is well-done, spanning SCSS, client-side Dart, and a server-side Jaspr extension. The code is clean and effective. I have a couple of suggestions for global_scripts.dart to enhance code robustness and conciseness.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Nov 6, 2025

Visit the preview URL for this PR (updated for commit 32b144a):

https://flutter-docs-prod--pr12654-feat-glossary-tooltip-xhqnklmd.web.app

@schultek schultek force-pushed the feat/glossary-tooltip branch from 251f22b to 32b144a Compare November 6, 2025 11:03
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for migrating this over! Looks great to me :D

@parlough parlough merged commit ca8bd74 into main Nov 7, 2025
9 checks passed
@parlough parlough deleted the feat/glossary-tooltip branch November 7, 2025 18:37
sfshaza2 pushed a commit that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants