Skip to content

Conversation

@iakdis
Copy link
Contributor

@iakdis iakdis commented Nov 11, 2025

Description of what this PR is changing or adding, and why: This PR changes the link to Writing efficient shaders that is found under https://docs.flutter.dev/ui/design/graphics/fragment-shaders#performance-considerations. It seems that after relocating the engine docs (flutter/flutter@e068a3e), this link didn't change accordingly.

Issues fixed by this PR (if any): #12665

PRs or commits this PR depends on (if any):

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@iakdis iakdis requested review from a team and sfshaza2 as code owners November 11, 2025 11:42
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @iakdis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical documentation issue by correcting an outdated link within the Flutter website's fragment shaders guide. The change ensures that users can properly access the 'Writing efficient shaders' resource, which had become inaccessible due to a previous relocation of engine documentation. This update improves the overall accuracy and usability of the Flutter documentation.

Highlights

  • Broken Link Fix: This pull request resolves a broken link in the fragment-shaders.md documentation file, specifically for the 'Writing efficient shaders' guide.
  • Documentation Path Update: The link's path has been updated from engine/src/flutter/impeller/docs/shader_optimization.md to docs/engine/impeller/docs/shader_optimization.md to reflect recent changes in the engine documentation structure.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @iakdis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical documentation issue by fixing a broken link within the Flutter website's fragment shaders guide. The change updates the URL for the 'Writing efficient shaders' resource, which had become invalid following a recent reorganization of the engine documentation. This ensures that developers can seamlessly access important performance optimization information for shaders.

Highlights

  • Broken Link Fix: Corrected a broken link in the fragment-shaders.md documentation file.
  • Documentation Update: The link to the 'Writing efficient shaders' guide was updated to reflect the new location of the engine documentation.
  • Path Correction: The URL path was changed from engine/src/flutter/impeller/docs/shader_optimization.md to docs/engine/impeller/docs/shader_optimization.md.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully addresses the broken link in fragment-shaders.md by updating the path to the shader_optimization.md document. This is a straightforward and correct fix, improving the overall accuracy and maintainability of the documentation.

@parlough
Copy link
Member

/gcbrun

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit f3d725d):

https://flutter-docs-prod--pr12667-main-e51lj9aa.web.app

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks, @iakdis!

@sfshaza2 sfshaza2 merged commit b275016 into flutter:main Nov 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants