-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Fix broken link in fragment-shaders.md
#12667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @iakdis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical documentation issue by correcting an outdated link within the Flutter website's fragment shaders guide. The change ensures that users can properly access the 'Writing efficient shaders' resource, which had become inaccessible due to a previous relocation of engine documentation. This update improves the overall accuracy and usability of the Flutter documentation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Summary of ChangesHello @iakdis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical documentation issue by fixing a broken link within the Flutter website's fragment shaders guide. The change updates the URL for the 'Writing efficient shaders' resource, which had become invalid following a recent reorganization of the engine documentation. This ensures that developers can seamlessly access important performance optimization information for shaders. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request successfully addresses the broken link in fragment-shaders.md by updating the path to the shader_optimization.md document. This is a straightforward and correct fix, improving the overall accuracy and maintainability of the documentation.
|
/gcbrun |
|
Visit the preview URL for this PR (updated for commit f3d725d): |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks, @iakdis!
Description of what this PR is changing or adding, and why: This PR changes the link to Writing efficient shaders that is found under https://docs.flutter.dev/ui/design/graphics/fragment-shaders#performance-considerations. It seems that after relocating the engine docs (flutter/flutter@e068a3e), this link didn't change accordingly.
Issues fixed by this PR (if any): #12665
PRs or commits this PR depends on (if any):
Presubmit checklist
of 80 characters or fewer.