-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Document how to determine if an app is a flutter app #12668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to determine if an app is a flutter app #12668
Conversation
Summary of ChangesHello @reidbaker, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive documentation within the Android deployment guide, outlining various methods to identify whether an Android application package (APK) is built with Flutter. The added content provides both technical instructions using Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds valuable documentation on how to determine if an Android app is built with Flutter. The methods described are relevant and useful. My review includes several suggestions to improve formatting, clarity, and adherence to the Google Developer Documentation Style Guide. These changes will make the documentation easier to read and follow.
|
Visit the preview URL for this PR (updated for commit f77ca31): https://flutter-docs-prod--pr12668-i-170523-document-android-d-91rzmxbn.web.app |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, I wish I could turn off the bot, as it isn't adding a lot of clarity.
src/content/deployment/android.md
Outdated
| Why this works: | ||
| Flutter depends on c++ code that we call the flutter engine. That code in android is bundled as an “.so” native library. | ||
| For the life of flutter that file has been named libflutter.so with the flutter framework and developers dart code being | ||
| combined into libapp.so. Flutter code names this library flutter and java/android tooling renames it with the lib prefix | ||
| and handles library location across architectures. This is what many reverse engineers use to identify flutter apps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Why this works: | |
| Flutter depends on c++ code that we call the flutter engine. That code in android is bundled as an “.so” native library. | |
| For the life of flutter that file has been named libflutter.so with the flutter framework and developers dart code being | |
| combined into libapp.so. Flutter code names this library flutter and java/android tooling renames it with the lib prefix | |
| and handles library location across architectures. This is what many reverse engineers use to identify flutter apps. | |
| **Why this works** | |
| Flutter depends on C++ code used by the Flutter engine. In Android, | |
| this code is bundled with the Flutter framework and the developer's | |
| Dart code as a native library called `libflutter.so`. | |
| The Java/Android tooling renames the `flutter` library with the `lib` prefix | |
| and handles library location across architectures. | |
| This is how some reverse engineer an APK to identify it as a Flutter app. |
Co-authored-by: Shams Zakhour <44418985+sfshaza2@users.noreply.github.com>
I thought it was pretty helpful. I adopted most of its suggestions |
|
I'm glad to hear that, Reid. I often find it helpful but, in this case, it needed further work, but it won't let me make changes on top of its changes and that frustrates me. (Since its changes are sometimes just wrong or just don't go far enough, etc.) |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description of what this PR is changing or adding, and why:
Documents how to tell from a built apk if the app uses flutter.
Internal documentation authored by me can be seen by googlers in go/flutter-android-detection
Issues fixed by this PR (if any):
flutter/flutter/issues/170523
PRs or commits this PR depends on (if any):
n/a
Presubmit checklist
of 80 characters or fewer.