-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Refactor user input radio buttons to use RadioGroup #12679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`groupValue` and `onChanged` parameter in `Radio` is deprecated after v3.32.0-0.0.pre
Summary of ChangesHello @autorejecttop, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the implementation of radio buttons in a user input example to align with recent Flutter API changes. It migrates the radio button group management from individual Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly refactors the radio button example to use the new RadioGroup widget, aligning with recent API changes in Flutter. The implementation is clear and effectively demonstrates the current best practice for creating groups of radio buttons. I've added one minor stylistic suggestion to improve code formatting consistency.
|
/gcbrun |
|
Visit the preview URL for this PR (updated for commit 7d65392): |
parlough
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on updating this!
The code change looks good to me, but the introduction text needs at least a few updates to match.
Here's some minimal suggestions to update it:
- Fixing documentation text to include `RadioGroup` Co-authored-by: Parker Lougheed <parlough@gmail.com>
- Forgot to include this one in the previous commit - Fixed documentation text to include `RadioGroup`
|
/gcbrun |
parlough
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those adjustments and for the thoughtful rewording. Looks good to me!
Description of what this PR is changing or adding, and why:
groupValueandonChangedparameter inRadiowidget is deprecated after v3.32.0-0.0.preIssues fixed by this PR (if any):
None
PRs or commits this PR depends on (if any):
None
Presubmit checklist
of 80 characters or fewer.