-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Exclude secondary Markdown files from sitemap #12685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @parlough, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the site's sitemap generation process by introducing a new exclusion rule. The change prevents secondary Markdown files, which are often generated alongside their primary HTML versions, from being included in the sitemap. This helps maintain a cleaner, more accurate sitemap by avoiding redundant entries and ensuring that search engines primarily index the canonical HTML content. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly excludes secondary Markdown files from the sitemap by adding a --sitemap-exclude argument with a regular expression to the jaspr build command. The change is simple and effective. I have one minor suggestion to improve code maintainability by extracting the hardcoded regex into a named constant.
|
Visit the preview URL for this PR (updated for commit b8b4416): https://flutter-docs-prod--pr12685-fix-markdown-sitemap-header-vcy6jxas.web.app |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
As their original HTML version is already present and these being indexed results in odd search results as seen by dart-lang/site-www#7017.