Skip to content

Conversation

@parlough
Copy link
Member

@parlough parlough commented Nov 13, 2025

As their original HTML version is already present and these being indexed results in odd search results as seen by dart-lang/site-www#7017.

@parlough parlough requested review from a team and sfshaza2 as code owners November 13, 2025 22:45
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @parlough, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the site's sitemap generation process by introducing a new exclusion rule. The change prevents secondary Markdown files, which are often generated alongside their primary HTML versions, from being included in the sitemap. This helps maintain a cleaner, more accurate sitemap by avoiding redundant entries and ensuring that search engines primarily index the canonical HTML content.

Highlights

  • Sitemap Exclusion: A new argument has been added to the site build command to exclude specific files from the sitemap generation.
  • Targeted Files: The exclusion rule specifically targets files ending with '.html.md', which are secondary Markdown outputs.
  • Reasoning: This change ensures that only the primary HTML versions of content are included in the sitemap, preventing duplicate entries for content that already exists in HTML format.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly excludes secondary Markdown files from the sitemap by adding a --sitemap-exclude argument with a regular expression to the jaspr build command. The change is simple and effective. I have one minor suggestion to improve code maintainability by extracting the hardcoded regex into a named constant.

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit b8b4416):

https://flutter-docs-prod--pr12685-fix-markdown-sitemap-header-vcy6jxas.web.app

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit b7d5e2d into main Nov 14, 2025
9 checks passed
@sfshaza2 sfshaza2 deleted the fix/markdown-sitemap-headers branch November 14, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants