-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Added example for toImageSync + setImageSampler #12686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @gaaclarke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the documentation for fragment shaders by providing practical examples of how to chain them together. The primary goal is to offer clearer guidance on using Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds an example demonstrating how to use toImageSync to generate an image from one shader and use it as a sampler in another shader. This is a valuable addition for clarifying how to chain shaders. My review focuses on improving the example code to align with Flutter's best practices for CustomPainter, specifically regarding state management and performance, to ensure the documentation provides a high-quality and efficient code sample.
|
This is more of a workaround than a fix for the cited issue. The work flow can be done - manually - with today's technology. But the issue that it claims it "fixes" is that users want to be able to just chain them together without having all of the glue code, isn't it? |
|
Visit the preview URL for this PR (updated for commit 6be2e2d): https://flutter-docs-prod--pr12686-chain-fragment-shaders-wa72cm4t.web.app |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok to me. @gaaclarke, can you address the bot's and @flar's feedback?
No, it was about adding the ability to do it. It was based on my ignorance and looking at the code of people doing liquid glass. Hopefully this example avoids that for people going forward. |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm, but I will wait for @flar to weigh in.
Description of what this PR is changing or adding, and why:
Adds more clarity about how to chain together fragment shaders.
Issues fixed by this PR (if any):
fixes flutter/flutter#177133
PRs or commits this PR depends on (if any):
Presubmit checklist
of 80 characters or fewer.