-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Update deprecated activeColor to activeThumbColor in Learn Flutter example code
#12691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @miinhho, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates an example code snippet in the Flutter documentation to reflect current best practices. It specifically addresses the deprecation of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly replaces the deprecated activeColor property with activeThumbColor in the Switch widget example. To provide a more complete and visually consistent example, I've suggested also setting activeTrackColor, as activeColor previously affected both the thumb and the track.
|
@ericwindmill, can you verify |
|
/gcbrun |
|
Visit the preview URL for this PR (updated for commit 82067a3): |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description of what this PR is changing or adding, and why:
Replaces the deprecated
activeColorproperty withactiveThumbColorin Learn Flutter example code (https://docs.flutter.dev/get-started/fundamentals/user-input#switch) to help new Flutter developers learn current best practices and avoid using deprecated APIs.Issues fixed by this PR (if any):
#12690
PRs or commits this PR depends on (if any):
Presubmit checklist
of 80 characters or fewer.