Skip to content

Conversation

@parlough
Copy link
Member

@parlough parlough commented Nov 18, 2025

This loop previously looped through items to render them but manually checked their values anyway. Instead of relying on harder to understand Liquid templating logic, just inline the intended cards.

Staged: https://flutter-docs-prod--pr12711-misc-widget-catalog-index-s-dzp1gfca.web.app/ui/widgets#design-systems

@parlough parlough requested review from a team and sfshaza2 as code owners November 18, 2025 02:59
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @parlough, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the presentation of design systems on the widget catalog index page by simplifying the underlying rendering logic. It transitions from dynamic Liquid templating to static component declarations for core design system cards, making the content definition more straightforward. Additionally, it refines the styling capabilities of the generic Card component and improves Markdown link formatting for better source readability.

Highlights

  • Simplified Widget Catalog Index Page: The rendering logic for the 'Design Systems' section on the widget catalog index page (src/content/ui/widgets/index.md) has been simplified by replacing a conditional Liquid templating loop with direct, inline Card component declarations for Cupertino and Material Design.
  • Enhanced Card Component Styling Control: The Card component (site/lib/src/components/common/card.dart) now allows explicit control over its filled state. Previously, a card with a link was always filled; now, filled='false' can override this behavior, providing more granular styling options.
  • Improved Markdown Link Readability: External links to community design systems on pub.dev within src/content/ui/widgets/index.md have been converted to use reference-style links, enhancing the readability of the Markdown source.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the widget catalog index page by replacing a Liquid template loop with hardcoded Card components, which improves readability. The change to use reference-style links in the markdown is also a good improvement.

I've added one suggestion in site/lib/src/components/common/card.dart to improve the consistency and robustness of how boolean attributes are handled for the Card component, which is modified in this PR.

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit f9afe41):

https://flutter-docs-prod--pr12711-misc-widget-catalog-index-s-dzp1gfca.web.app

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit d731338 into main Nov 18, 2025
9 checks passed
@sfshaza2 sfshaza2 deleted the misc/widget-catalog-index-simplify branch November 18, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants