-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Simplify design systems section on widget catalog index page #12711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @parlough, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the presentation of design systems on the widget catalog index page by simplifying the underlying rendering logic. It transitions from dynamic Liquid templating to static component declarations for core design system cards, making the content definition more straightforward. Additionally, it refines the styling capabilities of the generic Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request simplifies the widget catalog index page by replacing a Liquid template loop with hardcoded Card components, which improves readability. The change to use reference-style links in the markdown is also a good improvement.
I've added one suggestion in site/lib/src/components/common/card.dart to improve the consistency and robustness of how boolean attributes are handled for the Card component, which is modified in this PR.
|
Visit the preview URL for this PR (updated for commit f9afe41): https://flutter-docs-prod--pr12711-misc-widget-catalog-index-s-dzp1gfca.web.app |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This loop previously looped through items to render them but manually checked their values anyway. Instead of relying on harder to understand Liquid templating logic, just inline the intended cards.
Staged: https://flutter-docs-prod--pr12711-misc-widget-catalog-index-s-dzp1gfca.web.app/ui/widgets#design-systems