-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix: generate '/f/devtools-releases.json' on the Windows platform #12716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @AmosHuKe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical build error encountered when generating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly addresses a build failure on the Windows platform. The root cause was a hardcoded path string using forward slashes, which is not platform-agnostic. The change to use path.joinAll from the path package ensures that the path prefix for DevTools release notes is constructed correctly on any operating system. The fix is accurate and well-targeted, and I have no further recommendations.
|
/gcbrun |
|
Visit the preview URL for this PR (updated for commit c0e7ee5): |
parlough
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing and fixing this @AmosHuKe! Please do let me know if you hit any other issues on Windows. I appreciate it.
site/lib/src/components/pages/devtools_release_notes_index.dart
Outdated
Show resolved
Hide resolved
|
/gcbrun |
Description of what this PR is changing or adding, and why:
Running the
dart run dash_site build --releasecommand on the Windows platform results in an error:Issues fixed by this PR (if any):
PRs or commits this PR depends on (if any):
Presubmit checklist