Document how images work on the web #5061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
johnpryan
reviewed
Dec 8, 2020
|
|
||
| ### Use <img> in a platform view. | ||
|
|
||
| Flutter supports embedding HTML inside the app using [HtmlElementView][17]. Use |
Contributor
There was a problem hiding this comment.
Filed an issue to add sample code for this: #5063
johnpryan
approved these changes
Dec 8, 2020
harryterkelsen
approved these changes
Dec 8, 2020
sfshaza2
approved these changes
Dec 10, 2020
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
Very minor nits, otherwise LGTM!
| @@ -0,0 +1,161 @@ | |||
| --- | |||
| title: Displaying images on the web. | |||
Contributor
There was a problem hiding this comment.
Remove the period from the title.
| them. | ||
|
|
||
| # Background | ||
|
|
Contributor
There was a problem hiding this comment.
You must have at least one line of text between levels of headers.
|
|
||
| ### Host your images in a CORS-enabled CDN. | ||
|
|
||
| Typically content delivery networks (CDN) can be configured to customize what |
filiph
pushed a commit
to filiph/website
that referenced
this pull request
Feb 22, 2021
* Document how images work on the web * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the nuances of displaying images on the web. A question that's particularly common is how to render cross-origin images in CanvasKit.