Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable Javascript in iOS, support abort loading specific URLs #292

Merged
merged 7 commits into from Mar 28, 2019

Conversation

Projects
None yet
5 participants
@hnvn
Copy link
Member

commented Jan 8, 2019

I create this pull request to give WebView few features:

  • enable Javascript in iOS.
  • support abort loading specific URLs by using regex pattern. Native webview in Android and iOS will use this regex to determine to continue or abort loading an URL in method shouldOverrideUrlLoading in Android and webView:decidePolicyForNavigationAction:decisionHandler in iOS

hnvn added some commits Jan 8, 2019

Merge pull request #1 from fluttercommunity/master
Synchronize my fork to original repository
@sameerbakre

This comment has been minimized.

Copy link

commented Jan 16, 2019

Looks to be perfect answer to most of the problem we are having with this plugin.
When can we expect this to be available for downloading?

@charafau
Copy link
Collaborator

left a comment

enabling Javascript in iOS works as expected but for some reason it doesn't block URL redirection - at least when I click on twitter logo on flutter website, it gets redirected. Tested on iOS simulator

Show resolved Hide resolved example/lib/main.dart

@charafau charafau merged commit 8f1ad40 into fluttercommunity:master Mar 28, 2019

@evelyne24

This comment has been minimized.

Copy link

commented Apr 25, 2019

enabling Javascript in iOS works as expected but for some reason it doesn't block URL redirection - at least when I click on twitter logo on flutter website, it gets redirected. Tested on iOS simulator

The invalidUrlRegex doesn't appear to work with the WebviewScaffold?

@hnvn

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

Have a look at: #292 (comment)

@Raggaer

This comment has been minimized.

Copy link

commented May 3, 2019

How should I stop the loading tho? using invalidUrlRegex on the Scaffold works fine (blocks the redirect) but I want to detect the url and fire my own event, is that possible?

onUrlChanged only fires when the website is fully loaded.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.