Skip to content

Conversation

@lidongze91
Copy link
Contributor

Currently flutter supports a minimum SDK version of 16 and all plugins should be able to match it, anything lower than that will probably cause some unwanted issues. We need to add those into Android Manifest and properly document it, same goes with the functions.

@charafau
Copy link
Collaborator

Thank you for PR! I don't think we should specify minSdk in library, android manifests are merged in the end, so if someone sets his minSdk to 16 it will be 16 afaik.

Currently there's no sdk limitation (beside androidX limit) so I don't think we could benefit from this change.

@mehmetf
Copy link

mehmetf commented Jul 15, 2019

Android build system defaults your minSDK to 1 if you don't specify it. Gradle allows this but our internal BUILD system at Google throws warnings.

It is OK for us to set this to minSDK 1 explicitly but that's also misleading and confusing given that Flutter itself does not support anything lower than 16. That's why we are proposing this change.

@lidongze91
Copy link
Contributor Author

Thank you for PR! I don't think we should specify minSdk in library, android manifests are merged in the end, so if someone sets his minSdk to 16 it will be 16 afaik.

Currently there's no sdk limitation (beside androidX limit) so I don't think we could benefit from this change.

If we don't specify it, we only supports min SDK version of 1 which is not ideal given that Flutter only supports 16+. Relying on other android manifest file merged together would not be reliable. Could you review please? Thanks.

@lidongze91
Copy link
Contributor Author

Hi Rafal, would you do another review please?

@lidongze91
Copy link
Contributor Author

@charafau Hi Rafal, could you do another review please?

@charafau charafau merged commit 4d15be8 into fluttercommunity:master Aug 15, 2019
@charafau
Copy link
Collaborator

merged thanks!

charafau added a commit that referenced this pull request Apr 7, 2020
Add min sdk requirement and descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants