Skip to content

Migrate iOS Objective-C version to Swift #110

@diegotori

Description

@diegotori

iOS has known issues where it may not keep the screen on (affecting 16.4 and higher). Once I get myself an iOS device, I'm gonna port the code from Insomnia.swift into the iOS platform channel. The emulator may not be ideal for testing the wakelock.

Nevertheless, I do accept and will review PRs related to this. As long as it passes the existing integration tests, then it'll get merged and released.

If you submit a PR to this effect, then you will also have to update wakelock_plus_platform_interface and regenerate the pigeon classes so that they generate Swift instead of Objective-C.

As a bonus goal, if we can centralize the Darwin (iOS/MacOS) version into a single location, then we can simplify things further. That would involve creating a base protocol that gets implemented for both MacOS and iOS respectively. Then load up the correct one for each platform via static factory method.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions