Skip to content

api: Make ExternalArtifact conform to runtime Getter/Setter interface #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2025
Merged

api: Make ExternalArtifact conform to runtime Getter/Setter interface #1887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions api/v1/externalartifact_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,14 @@ type ExternalArtifactStatus struct {
Conditions []metav1.Condition `json:"conditions,omitempty"`
}

// GetRequeueAfter returns the duration after which the ExternalArtifact
// must be reconciled again.
func (in ExternalArtifact) GetRequeueAfter() time.Duration {
return time.Minute
// GetConditions returns the status conditions of the object.
func (in *ExternalArtifact) GetConditions() []metav1.Condition {
return in.Status.Conditions
}

// SetConditions sets the status conditions on the object.
func (in *ExternalArtifact) SetConditions(conditions []metav1.Condition) {
in.Status.Conditions = conditions
}

// GetArtifact returns the latest Artifact from the ExternalArtifact if
Expand All @@ -58,6 +62,12 @@ func (in *ExternalArtifact) GetArtifact() *meta.Artifact {
return in.Status.Artifact
}

// GetRequeueAfter returns the duration after which the ExternalArtifact
// must be reconciled again.
func (in *ExternalArtifact) GetRequeueAfter() time.Duration {
return time.Minute
}

// +kubebuilder:object:root=true
// +kubebuilder:subresource:status
// +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp",description=""
Expand Down