Codex/workspace #2
Conversation
…-utility-functions Add implementations for core JavaScript utility functions
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (keysA.length !== keysB.length) { | ||
| return false; | ||
| } | ||
|
|
||
| return keysA.every((key) => Object.prototype.hasOwnProperty.call(other, key) && isEqual(value[key], other[key])); |
There was a problem hiding this comment.
The deep comparison relies solely on enumerable keys after the array and Date cases. Objects such as functions, RegExp instances, or boxed primitives expose no enumerable properties, so two different values of those types pass the key-length check and the every call and return true. For example, isEqual(() => 1, () => 2) or isEqual(/foo/, /bar/) currently evaluate as equal, which is almost certainly wrong for a generic equality helper. Consider detecting these types or falling back to strict identity for objects without enumerable properties.
Useful? React with 👍 / 👎.
No description provided.