Revert "Merge pull request #22 from Mirroar/phpstan-array-generics" a… #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vukanac
approved these changes
Aug 26, 2022
Contributor
vukanac
left a comment
vukanac
left a comment
There was a problem hiding this comment.
git diff 3.2.0 gives empty diff. All OK.
The users of the latest fix can continue to use commit hash as they are doing now,
and we get a clean master covered with tests to update to composer v2
generated binary and tag a new release without any tests broken.
Approving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are failing for the current master.
This reverts commit 7e2ccbb, reversing
changes made to 5bac909.