feat(tui): integrate bubblezone hitboxes #5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,21 @@ | ||
| # AGENTS | ||
|
|
||
| - Quick notes for working on this repo (Go Redis Work Queue) | ||
|
Check failure on line 3 in AGENTS.md
|
||
| - Things learned / want to remember when iterating fast | ||
| - Activity log | ||
| - Tasklist | ||
| - Ideas | ||
|
|
||
| --- | ||
| ## Important Information | ||
|
Check failure on line 10 in AGENTS.md
|
||
|
|
||
| ### Sections You Must Actively Maintain | ||
|
|
||
| It is **CRITICAL** to keep the following sections of this document up-to-date as you work. | ||
|
Check failure on line 14 in AGENTS.md
|
||
|
|
||
| - What You Should Know | ||
| - Working Tasklist | ||
| - Daily Activity Logs | ||
|
Check failure on line 18 in AGENTS.md
|
||
| ### Job Queue | ||
|
|
||
| This project is a legit job queue backed by Redis, implemented in Go. The aim is to build a robust, horizontally scalable job system, balancing powerful features against real-world pragmatism, and keep things easy to use and understand. | ||
|
|
@@ -133,7 +133,7 @@ | |
| ### Prioritized Backlog | ||
|
|
||
| - [x] TUI: Charts expand-on-click (Charts 2/3 vs Queues 1/3; toggle back on Queues click) | ||
| - [x] TUI: Integrate `bubblezone` for precise mouse hitboxes (tabs, table rows, future context menus) | ||
| - [ ] Real green: capacity planning/forecasting/policy simulator suite | ||
| - [ ] Real green: distributed tracing integration suite | ||
| - [ ] Real green: job budgeting suite | ||
|
|
@@ -858,4 +858,3 @@ | |
|
|
||
| ### Suggested Stabilization Order | ||
| advanced-rate-limiting → anomaly-radar-slo-budget → automatic-capacity-planning → breaker → calendar-view → canary-deployments → chaos-harness → collaborative-session → config → dlq-remediation-pipeline → event-hooks → exactly-once-patterns → exactly_once → forecasting → job-budgeting → job-genealogy-navigator → json-payload-studio → kubernetes-operator → long-term-archives → multi-tenant-isolation → patterned-load-generator → plugin-panel-system → policy-simulator → producer-backpressure → queue → queue-snapshot-testing → rbac-and-tokens → right-click-context-menus → smart-payload-deduplication → smart-retry-strategies → storage-backends → tenant → terminal-voice-commands → theme-playground → time-travel-debugger → visual-dag-builder → worker-fleet-controls → distributed-tracing-integration → redisclient → obs → admin → producer → reaper → worker → admin-api → multi-cluster-control → trace-drilldown-log-tail → tui | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ import ( | |
|
|
||
| func (m model) View() string { | ||
| // Tab bar | ||
| tabBar := m.buildTabBar() | ||
|
|
||
| headerText := fmt.Sprintf("Job Queue TUI — Redis %s", m.cfg.Redis.Addr) | ||
| if m.opts.Cluster != "" { | ||
|
|
@@ -137,7 +137,7 @@ func (m model) View() string { | |
| tblH = 3 | ||
| } | ||
| m.tbl.SetHeight(tblH) | ||
| leftBody := m.markTableZones(m.tbl.View()) | ||
| if fb := renderFilterBar(m); fb != "" { | ||
| leftBody = fb + "\n" + leftBody | ||
| } | ||
|
|
@@ -256,7 +256,7 @@ func (m model) View() string { | |
| base := tabBar + "\n" + header + "\n" + sub + "\n\n" + body | ||
| if m.confirmOpen { | ||
| // Use a full-screen scrim overlay that centers the modal and preserves header/body | ||
| return m.zones.Scan(renderOverlayScreen(m)) | ||
| } | ||
| now := time.Now().Format("15:04:05") | ||
| m.sb.SetContent("Redis "+m.cfg.Redis.Addr, "focus:"+focusName(m.focus), m.spinner.View(), now) | ||
|
|
@@ -265,7 +265,7 @@ func (m model) View() string { | |
| // Dim with scrim and center the help content | ||
| out = renderHelpOverlay(m, "") | ||
| } | ||
| return m.zones.Scan(out) | ||
| } | ||
|
|
||
| func summarizeKeys(k admin.KeysStats) string { | ||
|
|
@@ -380,3 +380,43 @@ func renderFilterBar(m model) string { | |
| } | ||
| return "Press 'f' to filter queues" | ||
| } | ||
|
|
||
| func (m model) tabZoneID(id tabID) string { | ||
| return fmt.Sprintf("%s-tab-%d", m.tabZonePrefix, id) | ||
| } | ||
|
|
||
| func (m model) tableRowZoneID(idx int) string { | ||
| return fmt.Sprintf("%s-row-%d", m.tableZonePrefix, idx) | ||
| } | ||
|
|
||
| func (m model) visibleRowRange() (int, int) { | ||
| rows := m.tbl.Rows() | ||
| if len(rows) == 0 { | ||
| return 0, 0 | ||
| } | ||
| height := m.tbl.Height() | ||
| cursor := clamp(m.tbl.Cursor(), 0, len(rows)-1) | ||
| start := clamp(cursor-height, 0, cursor) | ||
| end := clamp(cursor+height, cursor, len(rows)) | ||
| if start > end { | ||
| start = end | ||
| } | ||
| return start, end | ||
| } | ||
|
Comment on lines
+392
to
+405
There was a problem hiding this comment. What is this AMATEUR HOUR boundary checking?! Your Either FIX your math so this condition can never occur, or add a proper assertion/panic: func (m model) visibleRowRange() (int, int) {
rows := m.tbl.Rows()
if len(rows) == 0 {
return 0, 0
}
height := m.tbl.Height()
cursor := clamp(m.tbl.Cursor(), 0, len(rows)-1)
start := clamp(cursor-height, 0, cursor)
end := clamp(cursor+height, cursor, len(rows))
- if start > end {
- start = end
+ if start > end {
+ // This should never happen with correct clamping logic
+ if m.logger != nil {
+ m.logger.Error("visibleRowRange: invalid range calculated",
+ zap.Int("start", start),
+ zap.Int("end", end),
+ zap.Int("cursor", cursor),
+ zap.Int("height", height))
+ }
+ return cursor, cursor + 1 // Return single row as fallback
}
return start, end
}
🤖 Prompt for AI Agents |
||
|
|
||
| func (m model) markTableZones(tableView string) string { | ||
| lines := strings.Split(tableView, "\n") | ||
| if len(lines) <= 1 { | ||
| return tableView | ||
| } | ||
| start, end := m.visibleRowRange() | ||
| rowIdx := start | ||
| for i := 1; i < len(lines) && rowIdx < end; i++ { | ||
| if strings.TrimSpace(lines[i]) == "" { | ||
| continue | ||
| } | ||
| lines[i] = m.zones.Mark(m.tableRowZoneID(rowIdx), lines[i]) | ||
| rowIdx++ | ||
| } | ||
| return strings.Join(lines, "\n") | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nil check is good but WHERE'S THE ERROR LOGGING?!
You're silently returning false when zones is nil! This is a CRITICAL component failure that should at least log an error so developers know something is broken!
Add error logging when zones is nil:
func (m model) tabAtMouse(msg tea.MouseMsg) (tabID, bool) { if m.zones == nil { + if m.logger != nil { + m.logger.Error("tabAtMouse called with nil zones manager") + } return 0, false }📝 Committable suggestion
🤖 Prompt for AI Agents