Set file timestamp to pubdate and save more id3 information #213

devalnor · 2017-08-12T01:01:15Z

Fix issue #166
Inspired from youtube-dl
Not tested on Windows but it work on OSX and probably on Unix based system.

Fix issue scdl-org#166 Inspired from youtube-dl Not tested on Windows but it work on OSX and probably on Unix based system.

flyingrub · 2017-08-13T16:20:43Z

Hi ! thanks for your PR ! Unfortunately your patch is crashing on my laptop.

Traceback (most recent call last):
  File "/usr/bin/scdl", line 11, in <module>
    load_entry_point('scdl==1.6.6', 'console_scripts', 'scdl')()
  File "/usr/lib/python3.6/site-packages/scdl-1.6.6-py3.6.egg/scdl/scdl.py", line 159, in main
  File "/usr/lib/python3.6/site-packages/scdl-1.6.6-py3.6.egg/scdl/scdl.py", line 236, in parse_url
  File "/usr/lib/python3.6/site-packages/scdl-1.6.6-py3.6.egg/scdl/scdl.py", line 463, in download_track
NameError: name 'datetime' is not defined

flyingrub · 2017-08-13T16:22:11Z

scdl/scdl.py

                logger.debug(e)
        else:
            logger.error("This type of audio doesn't support tagging...")
+


You have trailing whitespace here.

Oh! My bad. It's totally unprofessional.
My first and last time I submit patch directly with the github editor code.
Specially when it's late in the night >_<

flyingrub · 2017-08-13T16:25:40Z

scdl/scdl.py

        logger.info('\nTrack n°{0}'.format(counter))
        download_track(track)

+def try_utime(path, filetime):


Why are you wrapping this in a try catch ?

The idea was inspired from youtube-dl.

But in general using a try catch will prevent breaking change of your code. And like I said I did not test it on Windows.

flyingrub · 2017-08-13T16:26:01Z

scdl/scdl.py

+        audio['COMM'] = mutagen.id3.COMM(encoding=3, text=track['description'])
+        audio['TYER'] = mutagen.id3.TYER(encoding=3, text=track['created_at'][:4])
+        audio['WOAS'] = mutagen.id3.WOAS(url=track['permalink_url'])
+


Trailing whitespace.

flyingrub · 2017-08-13T16:26:56Z

scdl/scdl.py

+
+        #Try to change the real creation date
+        created_at = track['created_at']
+        filetime = int(time.mktime(datetime.strptime(created_at, '%Y/%m/%d %H:%M:%S %z').timetuple()))


datetime doesn't seem initialized.

You can have a look at 0736cb0#diff-834ccb1f68cfeac6d63b0b550a320ba0R467 for inspiration

Missing import.
from datetime import datetime

flyingrub · 2017-08-13T16:27:30Z

scdl/scdl.py

+        #Try to change the real creation date
+        created_at = track['created_at']
+        filetime = int(time.mktime(datetime.strptime(created_at, '%Y/%m/%d %H:%M:%S %z').timetuple()))
+        try_utime(os.path.join(os.getcwd(), filename),filetime)


You can use relative path here :)
try_utime(filename, filetime)

flyingrub · 2017-08-15T13:34:45Z

There is still trailing whitespace. Also the id3 tag editing doesn't seems to work. You can have a look at #147.

devalnor

Tested and working well on OSX.
You can check ID3 tags results with eyed3 (nice tool btw)

devalnor · 2017-08-14T10:04:46Z

scdl/scdl.py

+
+        #Try to change the real creation date
+        created_at = track['created_at']
+        filetime = int(time.mktime(datetime.strptime(created_at, '%Y/%m/%d %H:%M:%S %z').timetuple()))


Missing import.
from datetime import datetime

devalnor · 2017-08-17T14:13:48Z

scdl/scdl.py

        else:
            logger.error('Artwork can not be set.')
-    audio.save()
+    audio.save(v2_version=3)


Changed TagID to 2.3 instead of 2.4.
More stable and fix the date issue:
https://stackoverflow.com/questions/18026516/some-mutagen-tags-dont-work

devalnor · 2017-08-17T14:13:57Z

scdl/scdl.py

        shutil.copyfileobj(response.raw, out_file)
        out_file.seek(0)

+        track_date = datetime.strptime(track['created_at'], "%Y/%m/%d %H:%M:%S %z")


Inspired from @sublimo's fork.

flyingrub · 2017-08-17T14:18:38Z

looks good :)
what about this : https://github.com/flyingrub/scdl/pull/213/files/44acf4133f1afa493815ac314ebca809c4b31789#r132846316 ?

flyingrub · 2017-08-19T11:45:48Z

Audio source URL: b'http://soundcloud.com/le_lab/digital-harmonic\x00'

You need to add .encode('utf8') to the string there.

devalnor · 2017-08-20T11:45:32Z

Audio source URL are not encode in utf-8 why do you want to do that?

flyingrub · 2017-08-20T21:54:25Z

The string is a python bytecode object. That's why there is a b'...'

devalnor · 2017-08-30T08:41:03Z

@flyingrub after testing, I can't reproduce your issue.
If I encode the string in utf8 like you suggest by doing track['permalink_url'].encode('utf8'), eyeD3 return Audio source URL: b'http://soundcloud.com/...' but without I have a correct string Audio source URL: http://soundcloud.com/...

Is there something that I missing or can you explain me more the issue?

flyingrub · 2017-08-30T23:19:08Z

OK. So I was using eyeD3 with python3 and it seems that it doesn't support well the encoding when it run on python3. After using it on python2 it works well.

Set file timestamp to pubdate and save more id3 information

21f4f5c

Fix issue scdl-org#166 Inspired from youtube-dl Not tested on Windows but it work on OSX and probably on Unix based system.

flyingrub requested changes Aug 13, 2017

View reviewed changes

Update scdl.py

2440096

devalnor mentioned this pull request Aug 14, 2017

Download tracks that have been commented by user #215

Merged

flyingrub mentioned this pull request Aug 15, 2017

wav/flac to mp3, more ID3 tags #147

Closed

devalnor added 2 commits August 17, 2017 16:11

Update scdl.py

44acf41

Update scdl.py

9688e37

devalnor commented Aug 17, 2017

View reviewed changes

Use use relative

3a47544

flyingrub closed this Aug 30, 2017

flyingrub reopened this Aug 30, 2017

flyingrub approved these changes Aug 30, 2017

View reviewed changes

flyingrub merged commit 7bde733 into scdl-org:master Aug 30, 2017

devalnor deleted the patch-1 branch September 1, 2017 10:29

Set file timestamp to pubdate and save more id3 information #213

Set file timestamp to pubdate and save more id3 information #213

Uh oh!

Conversation

devalnor commented Aug 12, 2017

Uh oh!

flyingrub commented Aug 13, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flyingrub commented Aug 15, 2017

Uh oh!

devalnor left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flyingrub commented Aug 17, 2017

Uh oh!

flyingrub commented Aug 19, 2017

Uh oh!

devalnor commented Aug 20, 2017

Uh oh!

flyingrub commented Aug 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devalnor commented Aug 30, 2017

Uh oh!

flyingrub commented Aug 30, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

flyingrub commented Aug 20, 2017 •

edited

Loading