Skip to content

Do not attempt to jsonify response data #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Do not attempt to jsonify response data #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions fdk/response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ def __init__(self, response_data=None, headers=None, status_code=200):
"""
JSON response object
:param response_data: JSON response data (dict, str)
:type response_data: object
:type response_data: str
:param headers: JSON response HTTP headers
:type headers: fdk.headers.GoLikeHeaders
:param status_code: JSON response HTTP status code
:type status_code: int
"""
self.status_code = status_code
self.response_data = ujson.dumps(response_data)
self.response_data = response_data if response_data else ""
self.headers = hrs.GoLikeHeaders({})
if isinstance(headers, dict):
self.headers = hrs.GoLikeHeaders(headers)
Expand Down Expand Up @@ -79,7 +79,7 @@ def __init__(self, context, response_data=None,
:param context: request context
:type context: fdk.context.RequestContext
:param response_data: response data
:type response_data: object
:type response_data: str
:param headers: response headers
:param status_code: status code
:type status_code: int
Expand Down
11 changes: 11 additions & 0 deletions fdk/tests/test_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ async def coroutine_func(ctx, data=None, loop=None):
return "OK"


def none_func(ctx, data=None, loop=None):
return


class TestJSONRequestParser(testtools.TestCase):

def setUp(self):
Expand Down Expand Up @@ -96,3 +100,10 @@ def test_corotuine_func_multiple(self):
self.assertIsNotNone(r)
self.assertEqual(200, r.status())
self.assertIn("OK", r.body())

def test_none_func(self):
in_bytes = data.raw_request_without_body.encode('utf8')
r = runner.handle_request(none_func, in_bytes)
self.assertIsNotNone(r)
self.assertEqual(200, r.status())
self.assertIn("", r.body())