Skip to content

Added support for Elastic Network Interfaces#810

Closed
maf23 wants to merge 2 commits intofog:masterfrom
maf23:network-interface
Closed

Added support for Elastic Network Interfaces#810
maf23 wants to merge 2 commits intofog:masterfrom
maf23:network-interface

Conversation

@maf23
Copy link
Copy Markdown
Contributor

@maf23 maf23 commented Mar 22, 2012

The code supports all the documented network interface API calls.
Mockups and unit tests are included.

I have tried to run all unit tests (in mocking mode) and I do get some errors, but I do not think they are related to this patch.

@estonfer
Copy link
Copy Markdown
Member

Sorry for the delay, last week was a bit on the hectic side, I'll try and have this reviewed today.

@maf23
Copy link
Copy Markdown
Contributor Author

maf23 commented Mar 26, 2012

No problems. I'm running on a local copy anyway since I need this code now,
but do not expect you to roll a new release immediately.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and I thought I had removed all debug code :(

maf23 added 2 commits March 27, 2012 11:43
Additional changes since first commit
* Fixed to work in ruby 1.8.7
* Removed debug remains
@maf23
Copy link
Copy Markdown
Contributor Author

maf23 commented Mar 27, 2012

I just updated the pull request. I have removed the 'pp' require. I also ran the tests in mocking mode under ruby 1.8.7 and fixed the problems which turned up.

@estonfer
Copy link
Copy Markdown
Member

looks good, one more thing if it's not too much trouble, could we get an attach test in non-mocking mode? You should be able to just create an instance in the VPC that you created.

Thanks
Eric

@geemus
Copy link
Copy Markdown
Member

geemus commented Mar 27, 2012

@estonfer thanks for taking the lead on this, I didn't feel like I had enough context to cover it.

@estonfer
Copy link
Copy Markdown
Member

estonfer commented Apr 2, 2012

@maf23 I modified the tests on a local branch and then pushed it with credit to you. Thanks very much for all the excellet work.

935c634

@estonfer estonfer closed this Apr 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants