Added support for Elastic Network Interfaces#810
Conversation
|
Sorry for the delay, last week was a bit on the hectic side, I'll try and have this reviewed today. |
|
No problems. I'm running on a local copy anyway since I need this code now, |
There was a problem hiding this comment.
Yes, and I thought I had removed all debug code :(
Additional changes since first commit * Fixed to work in ruby 1.8.7 * Removed debug remains
|
I just updated the pull request. I have removed the 'pp' require. I also ran the tests in mocking mode under ruby 1.8.7 and fixed the problems which turned up. |
|
looks good, one more thing if it's not too much trouble, could we get an attach test in non-mocking mode? You should be able to just create an instance in the VPC that you created. Thanks |
|
@estonfer thanks for taking the lead on this, I didn't feel like I had enough context to cover it. |
The code supports all the documented network interface API calls.
Mockups and unit tests are included.
I have tried to run all unit tests (in mocking mode) and I do get some errors, but I do not think they are related to this patch.