Sdist and wheel#235
Merged
Merged
Conversation
Just for using setuptools-scm, which makes it easier to keep the files included in the sdist in sync.
…l does not contain a tool.setuptools_scm section'
* print to stdout and stderr everything
…- pretending there aren't any
1) no longer needed since using src layout 2) this produced empty wheels
fohrloop
force-pushed
the
sdist-and-wheel
branch
from
b8dc42f to
2179cca
Compare
Member
Author
|
The build and tests work well when running locally. In GitHub Actions the python 3.7 fails to build. That's a pipeline issue which I'm going to address in a separate PR. The wheel should anyway be built once and tested with multiple platforms and versions of python. Merging this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create sdists with also docs + tests included and wheels with just the wakepy package. Sdists will contain all the repo contents that is not gitignored (using setuptools-scm). This way the sdist will always have all contents required to run tests, create documentation and create the wakepy wheel.
Version string & tuple
Take the version from git tags using setuptools-scm. The setuptools-scm is also responsible of creating wakepy._version
module from which wakepy.__version__ and wakepy.version_tuple are read. Previously, the version string was defined in wakepy.__init__.py as variable (__version__).
Improve the build process: Now all errors are printed to stderr (tox colors these with red) and there is possibility to filter errors.
Transition from flit to setuptools. Just for setuptools-scm.