Add stricter mypy rules#243
Merged
Merged
Conversation
fohrloop
force-pushed
the
stricter-mypy-pt2
branch
from
9f76d67 to
330c246
Compare
that seems to be required.
Also removed the skip_intall=True in tox 'check' environment. (this made things easier as wakepy.__init__ requires wakepy._version to be present which is created in a build step, which is only done if skip_install is not True, and if the wakepy._version is not available, mypy would complain about it. And if we ignore the import line, mypy will next complain about unused ignores (when the wakepy._version file is present).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add stricter mypy rules
New rules
disallow_any_unimported = true
warn_unused_ignores = true
exclude folders better
exclude folders from mypy a bit better (mypy has to do less unnecessary
work)
Build when running tox -e check
Also removed the skip_intall=True in tox 'check' environment. (this made
things easier as wakepy.init requires wakepy._version to be present
which is created in a build step, which is only done if skip_install is
not True, and if the wakepy._version is not available, mypy would complain
about it. And if we ignore the import line, mypy will next complain about
unused ignores (when the wakepy._version file is present).