Skip to content

Conversation

@halamix2
Copy link

@halamix2 halamix2 commented Apr 8, 2023

Polish DOS game Pył (PCGamingWiki, exe) from 1998 currently have issues during the scan:

  • the game uses tbytes (and probably fwords if I'm reading asm correctly) , this PR should fix parsing errors
[1680991175] [ERROR   ] Failed to interpret access size: ['TBYTE']
[1680991175] [ERROR   ] Failed to interpret access size: ['TBYTE']
[1680991175] [ERROR   ] Failed to interpret access size: ['TBYTE']
[1680991175] [ERROR   ] Failed to interpret access size: ['TBYTE']
[1680991175] [ERROR   ] Failed to interpret access size: ['TBYTE']
[1680991175] [ERROR   ] Failed to interpret access size: ['TBYTE']
[1680991175] [ERROR   ] Failed to interpret access size: ['TBYTE']
[1680991175] [ERROR   ] Failed to interpret access size: ['TBYTE']
[1680991175] [ERROR   ] Failed to interpret access size: ['TBYTE']
[1680991175] [ERROR   ] Failed to interpret access size: ['TBYTES']
  • wdump Fixup Record Table can return empty target off
    • example 02 00 src off = 039D object # = 05 target off =
    • I'm not sure if wcdatool should default target offset to 0
    • I've used open-watcom Last-CI-build (commit 60f78534a5f154711579d567642b3cb7cead2185)

@halamix2
Copy link
Author

halamix2 commented Apr 8, 2023

The same TODOs as for fword may apply , as tbyte is defined as unsigned long long + unsigned short

https://github.com/open-watcom/open-watcom-v2/blob/master/bld/wasm/h/tbyte.h

@halamix2 halamix2 changed the title Add tbytes support Fix Pył analysis Apr 8, 2023
@fonic
Copy link
Owner

fonic commented Apr 9, 2023

Hi halamix2,
thank you for this.

This was bad timing - there is a newer version of wcdatool that I haven't uploaded yet (which both deals with those kind of fixups and adds support for TBYTES). Although I seem to have missed some parts regarding the TBYTES support, I'll check your commits for that.

Could you please test this version first?
<deleted, see comment below>

@fonic
Copy link
Owner

fonic commented Apr 9, 2023

I ported the missing parts from your commit to the new version:
wcdatool.zip

Thank you very much, this was a nice addition! Too bad that this version of Pył does not contain debug symbols.

@halamix2
Copy link
Author

halamix2 commented Apr 9, 2023

Thank you, I'll close this PR then :)

@halamix2 halamix2 closed this Apr 9, 2023
@halamix2 halamix2 deleted the fix/pyl branch April 9, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants