Skip to content

Conversation

@jfeingold35
Copy link
Contributor

@jfeingold35 jfeingold35 commented Mar 1, 2024

This PR refactors the tests that pertain to scanner rule list's interactions with CPD, and the scanner run tests that pertain to targeting.
Other tests still remain to be refactored.

@jfeingold35 jfeingold35 marked this pull request as ready for review March 1, 2024 22:18
@jfeingold35 jfeingold35 changed the title CHANGE (CodeAnalyzer): Refactored some more tests CHANGE (CodeAnalyzer): @W-14645433@: Refactored some more tests Mar 1, 2024
assertPerformanceViolations(results, target);
});

it('With a tilde-style path', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were using '... with' but here you have 'With'... I don't care - but I thought I'd let you know in case you did. :-)

@jfeingold35 jfeingold35 merged commit 6a970d7 into dev Mar 1, 2024
@jfeingold35 jfeingold35 deleted the d/W-14645433-b branch March 13, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants