Skip to content

CHANGE (DevOps): @W-15896661@: Update publish script to make v4 use latest tag for June release #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024
Merged

CHANGE (DevOps): @W-15896661@: Update publish script to make v4 use latest tag for June release #1492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/0-scanner_run_bug.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ body:
description: |
What do you get from the command "sf plugins"?
placeholder: |
Example: @salesforce/sfdx-scanner 4.1.0 (latest-beta)
Example: @salesforce/sfdx-scanner 4.3.0 (latest)
Copy link
Contributor Author

@stephen-carter-at-sf stephen-carter-at-sf May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I was in here, I figured I update our examples in our issue templates to not use a beta release as an example version.

validations:
required: true
- type: textarea
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/1-scanner_run_dfa_bug.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ body:
description: |
What do you get from the command "sf plugins"?
placeholder: |
Example: @salesforce/sfdx-scanner 4.1.0 (latest-beta)
Example: @salesforce/sfdx-scanner 4.3.0 (latest)
validations:
required: true
- type: input
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/2-scanner_run_false_result.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ body:
description: |
What do you get from the command "sf plugins"?
placeholder: |
Example: @salesforce/sfdx-scanner 4.1.0 (latest-beta)
Example: @salesforce/sfdx-scanner 4.3.0 (latest)
validations:
required: true
- type: textarea
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/3-scanner_run_dfa_false_result.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ body:
description: |
What do you get from the command "sf plugins"?
placeholder: |
Example: @salesforce/sfdx-scanner 4.1.0 (latest-beta)
Example: @salesforce/sfdx-scanner 4.3.0 (latest)
validations:
required: true
- type: input
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish-to-npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
with:
ctc: false # We've been told we don't have to care about this until someone makes us care.
sign: true
tag: latest-beta-rc # Publish as a release candidate, so we can do our validations against it.
tag: latest-rc # Publish as a release candidate, so we can do our validations against it.
githubTag: ${{ github.event.release.tag_name || inputs.tag }}
secrets: inherit
# Step 3: Run smoke tests against the release candidate.
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
java-version: '11' # For now, Java version is hardcoded.
# Install SF, and the release candidate version.
- run: npm install -g @salesforce/cli
- run: sf plugins install @salesforce/sfdx-scanner@latest-beta-rc
- run: sf plugins install @salesforce/sfdx-scanner@latest-rc
# Log the installed plugins for easier debugging.
- run: sf plugins
# Attempt to run the smoke tests.
Expand All @@ -102,7 +102,7 @@ jobs:
node-version: 'lts/*'
- run: |
echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > ~/.npmrc
npm dist-tag add @salesforce/sfdx-scanner@${{ github.event.release.tag_name || inputs.tag }} latest-beta
npm dist-tag add @salesforce/sfdx-scanner@${{ github.event.release.tag_name || inputs.tag }} latest
# Step 5: Create a Pull Request for merging `main` into `dev`
create-main2dev-pull-request:
needs: promote-to-latest
Expand Down