CHANGE (PMD): @W-15992482@: Upgrade to PMD 7.2.0 from 7.1.0 #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfeingold35
approved these changes
Jun 13, 2024
jag-j
reviewed
Jun 13, 2024
| import * as path from 'path'; | ||
|
|
||
| const PMD7_CLI_CLASS = 'net.sourceforge.pmd.cli.PmdCli'; | ||
| const HEAP_SIZE = '-Xmx1024m'; |
Contributor
There was a problem hiding this comment.
@stephen-carter-at-sf - Why are we not passing HEAP_SIZE anymore?
Contributor
Author
There was a problem hiding this comment.
See the discussion in slack. But the idea basically is to get around this bug https://salesforce-internal.slack.com/archives/G02JGHG9NSE/p1718287697404169?thread_ts=1718287579.150129&cid=G02JGHG9NSE
If we do not supply the heap size, then the default is roughly a 1/4 of whatever your machines memory is. Most machines have more than 4g of memory and thus this would naturally get set to higher than 1g. If not, then users can control this themselves with the JDK_JAVA_OPTIONS environment variable. For example:
export JDK_JAVA_OPTIONS="-Xmx2g"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.