NEW @W-16891765@ Config action mentions outfile #1649
Conversation
| # common.summary-header | ||
|
|
||
| Summary | ||
|
|
||
| # common.logfile-location | ||
|
|
||
| Additional log information written to: |
There was a problem hiding this comment.
Copied from run-summary-viewer.md. Named common.blah to allow for porting the existing RunSummaryViewer implementation to this new style.
|
|
||
| # config-action.no-outfiles | ||
|
|
||
| No output file was specified. |
There was a problem hiding this comment.
Analogous to run-summary-viewer.md's message "No results files were specified."
|
|
||
| No output file was specified. | ||
|
|
||
| # config-action.outfile-location |
There was a problem hiding this comment.
Analogous to run-summary-viewer.md's message "Results written to:".
| import {toStyledHeader, indent} from '../utils/StylingUtil'; | ||
| import {BundleName, getMessage} from '../messages'; | ||
|
|
||
| abstract class AbstractActionSummaryViewer { |
There was a problem hiding this comment.
There's only one child class right now, but the parent class will be helpful for porting the Run Summary Viewer to the new style.
| } | ||
|
|
||
| public async write(model: ConfigModel): Promise<void> { | ||
| public async write(model: ConfigModel): Promise<boolean> { |
There was a problem hiding this comment.
Since this method isn't guaranteed to actually write anything, it now returns a boolean to indicate whether it did.
| import {ConfigAction, ConfigDependencies, ConfigInput} from '../../../src/lib/actions/ConfigAction'; | ||
| import {AnnotatedConfigModel} from '../../../src/lib/models/ConfigModel'; | ||
| import {ConfigStyledYamlViewer} from '../../../lib/lib/viewers/ConfigViewer'; | ||
| import {ConfigStyledYamlViewer} from '../../../src/lib/viewers/ConfigViewer'; |
There was a problem hiding this comment.
Import path was wrong here.
| import {AnnotatedConfigModel} from '../../../src/lib/models/ConfigModel'; | ||
| import {ConfigStyledYamlViewer} from '../../../lib/lib/viewers/ConfigViewer'; | ||
| import {ConfigStyledYamlViewer} from '../../../src/lib/viewers/ConfigViewer'; | ||
| import {ConfigActionSummaryViewer} from '../../../src/lib/viewers/ActionSummaryViewer'; |
There was a problem hiding this comment.
Testing through ConfigAction using the actual implementation, instead of using an Interface/Stub setup.
|
|
||
| // ==== OUTPUT PROCESSING ==== | ||
| const displayEvents = spyDisplay.getDisplayEvents(); | ||
| expect(displayEvents).toHaveLength(1); |
There was a problem hiding this comment.
Array length is now variable, so we're not checking for an exact length anymore.
jfeingold35
force-pushed
the
d/W-16891765-b
branch
from
dfec6ef to
9407177
Compare
messages/action-summary-viewer.md
Outdated
|
|
||
| # config-action.outfile-location | ||
|
|
||
| Config written to: |
There was a problem hiding this comment.
| Config written to: | |
| Configuration written to: |
jshackell-sfdc
left a comment
jshackell-sfdc
left a comment
There was a problem hiding this comment.
Approved, but see my suggestion.
jfeingold35
force-pushed
the
d/W-16891765-b
branch
from
0c51e6e to
b03d267
Compare
| this.toYamlEngineOverrides() + '\n' + | ||
| '\n' + | ||
| this.toYamlSectionHeadingComment(getMessage(BundleName.ConfigModel, 'template.common.end-of-config')) + '\n'; |
There was a problem hiding this comment.
I think this end of config message might end up in the file as well. I was hoping it would just be for the terminal output only.
No description provided.