Skip to content

CHANGE @W-17100347@ Removed mentions of JUnit from CLI #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2024
Merged

CHANGE @W-17100347@ Removed mentions of JUnit from CLI #1675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion messages/results-writer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# error.unrecognized-file-format

The output file %s has an unsupported extension. Valid extensions include: .csv; .html/.htm; .json; .junit/.junit.xml; .sarif/.sarif.json; .xml.
The output file %s has an unsupported extension. Valid extensions include: .csv; .html/.htm; .json; .sarif/.sarif.json; .xml.
1 change: 0 additions & 1 deletion messages/run-command.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ If you don't specify this flag, the command outputs the results in the terminal.
- .csv
- .html or .htm
- .json
- .junit or .junit.xml
- .sarif or .sarif.json
- .xml

Expand Down
3 changes: 0 additions & 3 deletions src/lib/writers/ResultsWriter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ export class ResultsFileWriter implements ResultsWriter {
// Check for `.json` AFTER checking for `.sarif.json`!
} else if (ext === '.json') {
this.format = OutputFormat.JSON;
} else if (ext === '.junit' || file.toLowerCase().endsWith('.junit.xml')) {
throw new Error('TODO: Support JUNIT-type output');
// Check for `.xml` AFTER checking for `.junit.xml`!
} else if (ext === '.xml') {
this.format = OutputFormat.XML;
} else {
Expand Down
4 changes: 0 additions & 4 deletions test/lib/writers/ResultsWriter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ describe('ResultsWriter implementations', () => {
{ext: '.html', expectedOutput: `Results formatted as ${OutputFormat.HTML}`},
{ext: '.htm', expectedOutput: `Results formatted as ${OutputFormat.HTML}`},
{ext: '.json', expectedOutput: `Results formatted as ${OutputFormat.JSON}`},
//{ext: '.junit', expectedOutput: `Results formatted as ${OutputFormat.JUNIT}`},
//{ext: '.junit.xml', expectedOutput: `Results formatted as ${OutputFormat.JUNIT}`},
//{ext: '.sarif', expectedOutput: `Results formatted as ${OutputFormat.SARIF}`},
//{ext: '.sarif.json', expectedOutput: `Results formatted as ${OutputFormat.SARIF}`},
{ext: '.xml', expectedOutput: `Results formatted as ${OutputFormat.XML}`}
Expand All @@ -48,8 +46,6 @@ describe('ResultsWriter implementations', () => {
* in the case array for the valid format tests.
*/
it.each([
{ext: '.junit'},
{ext: '.junit.xml'},
{ext: '.sarif'},
{ext: '.sarif.json'}
])('Throws TODO error for not-yet-supported format: *$ext', ({ext}) => {
Expand Down