Skip to content

CHANGE: @W-17310939@: Update to use latest core and pmd engine #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2024
Merged

CHANGE: @W-17310939@: Update to use latest core and pmd engine #1701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a92c72
CHANGE: @W-17310939@: Update to use latest core and pmd engine
stephen-carter-at-sf Dec 20, 2024
38f03f4
Fix test by updating stub
stephen-carter-at-sf Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@
"bugs": "https://github.com/forcedotcom/sfdx-scanner/issues",
"dependencies": {
"@oclif/core": "^3.3.2",
"@salesforce/code-analyzer-core": "0.19.1",
"@salesforce/code-analyzer-core": "0.20.0",
"@salesforce/code-analyzer-engine-api": "0.16.1",
"@salesforce/code-analyzer-eslint-engine": "0.16.1",
"@salesforce/code-analyzer-flowtest-engine": "0.16.1",
"@salesforce/code-analyzer-pmd-engine": "0.16.1",
"@salesforce/code-analyzer-pmd-engine": "0.17.0",
"@salesforce/code-analyzer-regex-engine": "0.16.1",
"@salesforce/code-analyzer-retirejs-engine": "0.16.1",
"@salesforce/core": "^5",
Expand Down
8 changes: 8 additions & 0 deletions test/stubs/StubRunResults.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ import {EngineRunResults, RunResults, Violation} from '@salesforce/code-analyzer


export class StubEmptyResults implements RunResults {
getCoreVersion(): string {
throw new Error('Method not implemented.');
}

/**
* Based on the way the tests currently use this stub, this method is never called,
* so it should be fine for it to be unimplemented.
Expand Down Expand Up @@ -57,6 +61,10 @@ export class StubEmptyResults implements RunResults {
}

export class StubNonEmptyResults implements RunResults {
getCoreVersion(): string {
throw new Error('Method not implemented.');
}

getRunDirectory(): string {
throw new Error('Method not implemented.');
}
Expand Down
16 changes: 8 additions & 8 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1699,10 +1699,10 @@
strip-ansi "6.0.1"
ts-retry-promise "^0.8.1"

"@salesforce/code-analyzer-core@0.19.1":
version "0.19.1"
resolved "https://registry.yarnpkg.com/@salesforce/code-analyzer-core/-/code-analyzer-core-0.19.1.tgz#9703d5897adb7d5bb88d2ae714e4eaa85dbcdcbc"
integrity sha512-NCciOI0sNjrJljAMDV9O0zSmSTs1huXDJTKiRmss1PmMOcKpWfzqtOSWT0ZyE9W1g0PEfUxUiTsxVxlOoHItXA==
"@salesforce/code-analyzer-core@0.20.0":
version "0.20.0"
resolved "https://registry.yarnpkg.com/@salesforce/code-analyzer-core/-/code-analyzer-core-0.20.0.tgz#4f16eca0ca30a1dea1fb045e96ce2a7881f20fe1"
integrity sha512-vElirVhPSIZrgbFr+2jq14wxgONiQWLlIssYyCO2urTNPUD2AO09tZZtL7CLHyROtJuYaiQ4FxnkD4QKr48HEQ==
dependencies:
"@salesforce/code-analyzer-engine-api" "0.16.1"
"@types/js-yaml" "^4.0.9"
Expand Down Expand Up @@ -1753,10 +1753,10 @@
semver "^7.6.3"
tmp "^0.2.3"

"@salesforce/code-analyzer-pmd-engine@0.16.1":
version "0.16.1"
resolved "https://registry.yarnpkg.com/@salesforce/code-analyzer-pmd-engine/-/code-analyzer-pmd-engine-0.16.1.tgz#94306b171302e6ce52450036077029e431bcec43"
integrity sha512-OYrYfUA/xPL4w3LmYfZyv/U4hAjKs346gYnM3GT4hkOKO1AWDJbdE3ABI7EuM7VSntN6Gtwdh+vHCe/G/oZP0A==
"@salesforce/code-analyzer-pmd-engine@0.17.0":
version "0.17.0"
resolved "https://registry.yarnpkg.com/@salesforce/code-analyzer-pmd-engine/-/code-analyzer-pmd-engine-0.17.0.tgz#7af7f78c201131fa2cf0aca7dc7f73d436f3212c"
integrity sha512-28BTWEn2aWVbJKKV/UD5zydhAJz7dH5wJXZzV3NCi+Q9y9JzfiOzNMyEgkdqtvHS5hKfOo46d6gJcSFt9fr7ug==
dependencies:
"@salesforce/code-analyzer-engine-api" "0.16.1"
"@types/node" "^20.0.0"
Expand Down
Loading