NEW @W-17977844@ rules command can output csv files #1877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfeingold35
commented
Aug 14, 2025
| trim_trailing_whitespace = true | ||
| insert_final_newline = true | ||
|
|
||
| [*.ts] |
Contributor
Author
There was a problem hiding this comment.
Noticing that some of the files created by people other than me are space-indented, so I'm adding a thing to the .editorconfig to hopefully keep it all consistent in the future.
Comment on lines
+27
to
+42
| it.each([ | ||
| {ext: 'json', format: OutputFormat.JSON}, | ||
| {ext: 'csv', format: OutputFormat.CSV} | ||
| ])('Writes to a $ext file path', ({ext, format}) => { | ||
| const outfilePath = path.join('the', 'results', 'path', `file.${ext}`); | ||
| const expectations = { | ||
| file: outfilePath, | ||
| contents: `Rules formatted as ${format}` | ||
| }; | ||
| const rulesWriter = new RulesFileWriter(expectations.file); | ||
| const stubbedSelection = new Stub.StubEmptyRuleSelection(); | ||
| rulesWriter.write(stubbedSelection); | ||
|
|
||
| expect(writeFileSpy).toHaveBeenCalled(); | ||
| expect(writeFileInvocations).toEqual([expectations]); | ||
| }); | ||
| }); | ||
| expect(writeFileSpy).toHaveBeenCalled(); | ||
| expect(writeFileInvocations).toEqual([expectations]); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
I changed this test to use it.each(), and that's the only functional change. Everything else was just whitespace to make it tab-indented.
stephen-carter-at-sf
requested changes
Aug 14, 2025
stephen-carter-at-sf
requested changes
Aug 14, 2025
Contributor
stephen-carter-at-sf
left a comment
stephen-carter-at-sf
left a comment
There was a problem hiding this comment.
Don't we need to update the rules command so that the output-format has multiple: true so we can supply multiple?
stephen-carter-at-sf
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.