@W-11267130@: violation messages use <br> instead of \n in html #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Yeah, that's probably necessary to get the coverage up. You must have barely dropped it below acceptable minimums. |
jfeingold35
reviewed
Jun 16, 2022
| category: v.category, | ||
| url: v.url, | ||
| message: v.message, | ||
| message: verboseViolations && result.engine === 'retire-js' ? v.message.replace(/\n/g, '<br>') : v.message, // <br> used for line breaks in html |
Contributor
There was a problem hiding this comment.
This is unnecessary. RetireJS only returns pathless violations.
| category: v.category, | ||
| url: v.url, | ||
| message: v.message, | ||
| message: verboseViolations && result.engine === 'retire-js' ? v.message.replace(/\n/g, '<br>') : v.message, // <br> used for line breaks in html |
Contributor
There was a problem hiding this comment.
As in the other PR, import ENGINE from Constants.ts and use ENGINE.RETIRE_JS.
jfeingold35
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line breaks now occur when expected.
However, adding this code has cause a test error: Coverage for branches (79.96%) does not meet global threshold (80%)
Should constructHtml (and contructJson) have additional tests for when verboseViolations is true?