@W-11261233@ SFGE: adding ability to programmatically enable/disable rules #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmohan20
commented
Jul 6, 2022
| if (!Modifier.isAbstract(ruleType.getModifiers())) { | ||
| rules.add(getRuleInner(ruleType.getName())); | ||
| final AbstractRule rule = getRuleInner(ruleType.getName()); | ||
| if (rule.isEnabled()) { |
Contributor
Author
There was a problem hiding this comment.
Here's where we check if a rule is enabled or not before adding it.
Contributor
There was a problem hiding this comment.
I don't love that getAllRules() doesn't actually return all rules. Can we rename it to getEnabledRules()? Maybe still have a getAllRules() that does return all rules, and a helper method that both delegate to that accepts a boolean parameter?
Contributor
Author
There was a problem hiding this comment.
Valid point. Creating an update.
jfeingold35
approved these changes
Jul 6, 2022
rmohan20
force-pushed
the
rm/configToDisableSfgeRules
branch
from
6e68228 to
7e822f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each rule would now have control over enabling itself. By default, all SFGE rules are disabled.