@W-11404189@ Adding error message for unreachable code #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmohan20
commented
Jul 11, 2022
| * Contains error message constants that will be displayed to users. TODO: move all other | ||
| * user-facing messages here. | ||
| */ | ||
| public final class UserFacingErrorMessages { |
Contributor
Author
There was a problem hiding this comment.
Just a simple constants file at the moment, but as we move more messages to here, would be easier to switch to a different mechanism.
rmohan20
commented
Jul 11, 2022
| @SuppressWarnings("PMD.AbstractClassWithoutAbstractMethod") | ||
| abstract class AbstractApexVertexBuilder { | ||
| private static final Logger LOGGER = LogManager.getLogger(AbstractApexVertexBuilder.class); | ||
| protected static final Set<String> ROOT_VERTICES = |
Contributor
Author
There was a problem hiding this comment.
Moved this to GremlinUtil to avoid two-way reference between both the classes.
rmohan20
commented
Jul 11, 2022
| } | ||
| } | ||
|
|
||
| public static String getFileName(GraphTraversalSource g, Vertex vertex) { |
Contributor
Author
There was a problem hiding this comment.
New method to get filename from a vertex.
rmohan20
commented
Jul 11, 2022
|
|
||
| private void addEdge(String name, Vertex from, Vertex to) { | ||
| if (NodeType.TERMINAL_VERTEX_LABELS.contains(from.label())) { | ||
| throw new UnexpectedException("Vertex is terminal. vertex=" + vertexToString(from)); |
Contributor
Author
There was a problem hiding this comment.
Replacing the cryptic message.
jfeingold35
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.