@W-11397711@: Added banner requesting that people take our survey. #753
Conversation
| @@ -0,0 +1,3 @@ | |||
| module.exports = { | |||
| FEEDBACK_SURVEY_BANNER: `What do you think of Salesforce Code Analyzer? Take our feedback survey at https://research.net/r/SalesforceCA.` | |||
There was a problem hiding this comment.
Added a new common messages file instead of putting the banner as a constant.
| .it('Ensure normalized severity is not outputted when --normalize-severity not provided', ctx => { | ||
| const output = JSON.parse(ctx.stdout); | ||
| // The first line is a header. Strip that away, and parse the rest as JSON. | ||
| const output = JSON.parse(ctx.stdout.split('\n')[1]); |
There was a problem hiding this comment.
Can we move all the banner-related test fixes to a smaller area (such as a separate module with functions that can be invoked) so that there'll be less code to clean up once we remove the banner?
There was a problem hiding this comment.
@jfeingold35 @rmohan20 I have the same comments as PR 748 and PR 752. Can we discuss Monday afternoon via huddle?
So I would consider this message a toast, so let's follow CCX toast conventions.
My three suggestions:
"We released a new version of Salesforce Code Analyzer. Tell us what you think! Give Feedback."
OR
"We've improved Salesforce Code Analyzer. Tell us what you think! Give Feedback."
OR
"We're constantly improving Salesforce Code Analyzer. Tell us what you think! Give Feedback."
Link on Give Feedback-Can we include a Give Feedback button? To see more of what I'm talking about, check out the "spotlight on a toast" about 25% down this page: https://confluence.internal.salesforce.com/display/DOCTEAM/toast
rmohan20
left a comment
rmohan20
left a comment
There was a problem hiding this comment.
Had a minor comment about the spread of test changes. Overall, looks good to me.
jfeingold35
force-pushed
the
d/W-11397711-v3
branch
from
8c7d80d to
ddeb2e5
Compare
No description provided.