@W-10778096@ Minor error message fixes #770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfeingold35
approved these changes
Jul 22, 2022
rmohan20
commented
Jul 22, 2022
| public static final String UNRESOLVED_CRUD_FLS_TEMPLATE = | ||
| "SFGE was unable to resolve the parameter passed to [%2$s] operation. " | ||
| + "Ensure manually that this operation has the necessary CRUD/FLS checks."; | ||
| "SFGE couldn't resolve the parameter passed to [%2$s] operation%4$s. " |
Contributor
Author
There was a problem hiding this comment.
@jfeingold35 I've changed the format based on our conversation.
rmohan20
commented
Jul 22, 2022
| flsViolationInfo.getValidationType().name(), | ||
| flsViolationInfo.getObjectName()); | ||
| flsViolationInfo.getObjectName(), | ||
| fieldInformation); |
Contributor
Author
There was a problem hiding this comment.
Now passing in fieldInformation as another parameter.
rmohan20
commented
Jul 22, 2022
| message, | ||
| equalToIgnoringCase( | ||
| "FLS validation is missing for [UPDATE] operation on [My_Obj__c] with field(s) [Name,Status__c] - SFGE may not have parsed some objects/fields correctly. Please confirm if the objects/fields involved in these segments have FLS checks: [Relational_Field__r.Another_field__c]")); | ||
| String.format( |
Contributor
Author
There was a problem hiding this comment.
Modified failing tests to use String formats instead of hardcoding the message. Will clean up the remaining tests at another iteration while applying Teresa's feedback.
jfeingold35
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.