@W-10778080@ Handle unresolved apex value in DML statements gracefully #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmohan20
commented
Aug 1, 2022
| sourceCode, | ||
| expectUnresolvedCrudFls(3, FlsConstants.FlsValidationType.READ)); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Adding more test cases to get a repro of how far we can resolve apex values.
rmohan20
commented
Aug 1, 2022
Comment on lines
+166
to
+173
| if (LOGGER.isWarnEnabled()) { | ||
| LOGGER.warn( | ||
| "TODO: Apex value not detected for dml's child vertex: " + childVertex); | ||
| // TODO: add telemetry | ||
| } | ||
| violations.add( | ||
| FlsViolationCreatorUtil.createUnresolvedCrudFlsViolation( | ||
| validationType, vertex)); |
Contributor
Author
There was a problem hiding this comment.
Related action happens here
rmohan20
commented
Aug 1, 2022
Comment on lines
+180
to
+182
| violations.add( | ||
| FlsViolationCreatorUtil.createUnresolvedCrudFlsViolation( | ||
| validationType, vertex)); |
Contributor
Author
There was a problem hiding this comment.
This is possibly an unexpected situation - we haven't seen it anywhere or had a repro, but I'm modifying it so that users don't see an internal error for this.
jfeingold35
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an Unresolved CRUD/FLS violation when SFGE is unable to resolve an ApexValue