refactor: only the jszip matters

Author: mshanemc

src/convert/streams.ts

@@ -21,7 +21,6 @@ import { createWriteStream, existsSync, promises as fsPromises } from 'graceful-
 import { JsonMap } from '@salesforce/ts-types';
 import { XMLBuilder } from 'fast-xml-parser';
 import { Logger } from '@salesforce/core/logger';
-import { Global } from '@salesforce/core';
 import { SourceComponent } from '../resolve/sourceComponent';
 import { SourcePath } from '../common/types';
 import { XML_COMMENT_PROP_NAME, XML_DECL } from '../common/constants';
@@ -41,11 +40,6 @@ export type PromisifiedPipeline = <T extends NodeJS.ReadableStream>(
 
 let promisifiedPipeline: PromisifiedPipeline | undefined; // store it so we don't have to promisify every time
 
-// jszip does not behave well in web environments when retrieving multiple files.
-// it has a minified `browser` target which has a v3 ReadableStream, but the extensions are using polyfilles of v4.
-// Setting the highWaterMark to 1 seems to fix the issue.
-export const getStreamOptions = (): { highWaterMark?: number } => (Global.isWeb ? { highWaterMark: 1 } : {});
-
 export const getPipeline = (): PromisifiedPipeline => {
   promisifiedPipeline ??= promisify(cbPipeline);
   return promisifiedPipeline;

src/resolve/treeContainers.ts

@@ -21,9 +21,9 @@ import JSZip from 'jszip';
 import { Messages } from '@salesforce/core/messages';
 import { SfError } from '@salesforce/core/sfError';
 import { isString } from '@salesforce/ts-types';
+import { Global } from '@salesforce/core/global';
 import { baseName, parseMetadataXml } from '../utils/path';
 import type { SourcePath } from '../common/types';
-import { getStreamOptions } from '../convert/streams';
 import type { VirtualDirectory } from './types';
 
 Messages.importMessagesDirectory(__dirname);
@@ -203,7 +203,10 @@ export class ZipTreeContainer extends TreeContainer {
     if (resolvedPath) {
       const jsZipObj = this.zip.file(resolvedPath);
       if (jsZipObj && !jsZipObj.dir) {
-        return new Readable(getStreamOptions()).wrap(jsZipObj.nodeStream());
+        // jszip does not behave well in web environments when retrieving multiple files.
+        // it has a minified `browser` target which has a v3 ReadableStream, but the extensions are using polyfilles of v4.
+        // Setting the highWaterMark to 1 seems to fix the issue.
+        return new Readable(Global.isWeb ? { highWaterMark: 1 } : {}).wrap(jsZipObj.nodeStream());
       }
       throw new SfError(messages.getMessage('error_no_directory_stream', [this.constructor.name]), 'LibraryError');
     }