perf: optimize populateTypesAndNames component deduplication W-21991374#849
Merged
perf: optimize populateTypesAndNames component deduplication W-21991374#849
Conversation
Use Set-backed unique lists for deletes and non-deletes before resolution.
madhur310
approved these changes
Apr 11, 2026
CristiCanizales
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issues does this PR fix or reference?
@W-21991374@
Description
sourceComponentsarray into theuniqueSourceComponentsdeduplication chain, removing one full array allocation and traversaltest/nuts/local/populateTypesAndNames.nut.ts) covering: empty input, Apex class resolution, LWC bundle dedup across multiple input files, force-ignore detection via.forceignore, and unresolvable path handling with/withoutexcludeUnresolvableNote on NUT setup
TestSessionstubsprocess.cwd()via sinon without callingprocess.chdir. This causesmaybeGetTreeContainerto returnundefined, making the resolver use the real cwd (workspace root) for FS operations — which misses project files. NUT usesmkdtempSync+cpSyncinstead so real cwd ≠ projectPath.Made with Cursor