Skip to content

Clean gradle Project-Structure#756

Merged
ZacSweers merged 2 commits intopockethub:masterfrom
larsgrefer:gradleStructure
Jun 21, 2015
Merged

Clean gradle Project-Structure#756
ZacSweers merged 2 commits intopockethub:masterfrom
larsgrefer:gradleStructure

Conversation

@larsgrefer
Copy link
Copy Markdown
Contributor

Using a clean directory-structure for gradle including the instumentation-tests
#748

fixes #602
fixes #659

@larsgrefer larsgrefer force-pushed the gradleStructure branch 3 times, most recently from a6aa028 to 692abd3 Compare April 16, 2015 11:32
@larsgrefer
Copy link
Copy Markdown
Contributor Author

@jonan @fadils What is your option on dropping the maven and eclipse support and using a clean gradle build structure like mentioned here: http://developer.android.com/tools/building/configuring-gradle.html ?

@larsgrefer larsgrefer force-pushed the gradleStructure branch 2 times, most recently from 0bf4225 to 6c186f9 Compare April 16, 2015 23:32
@ZacSweers
Copy link
Copy Markdown
Contributor

This is solid, and much needed. With the number of changes though, it's going to break a lot of existing pull requests. Need to think about if it's better to bite the bullet and do this now, or try to resolve those first (but then you'd probably have to close and re-open after those updates). Leaning towards the latter, but since the work is on you for this I want to see what you think as well @larsgrefer

@larsgrefer
Copy link
Copy Markdown
Contributor Author

I think we should wait until the most mergeable pull requests are merged.
But in the meantime we can merge at least #754

I try to rebase this whenever needed so it stays mergeable

@ZacSweers
Copy link
Copy Markdown
Contributor

I'd rather just do them all together in one pull request, rather than have the same commit appear in both. I've commented/addressed most of the open PRs right now, so waiting for responses and hopefully should get them resolved soon.

@larsgrefer
Copy link
Copy Markdown
Contributor Author

Okay, but if you'd merge #754 i'll remove the commit from this PR

@ZacSweers
Copy link
Copy Markdown
Contributor

Still rather do them together in this pull request, please just wait.

@larsgrefer larsgrefer force-pushed the gradleStructure branch 6 times, most recently from 2e22baa to 06c2d58 Compare April 26, 2015 22:33
@larsgrefer larsgrefer force-pushed the gradleStructure branch 2 times, most recently from 9abf158 to 3f1a096 Compare May 7, 2015 11:28
@ZacSweers
Copy link
Copy Markdown
Contributor

Pulling the trigger on this. The other PRs I've responded to have had enough time

ZacSweers added a commit that referenced this pull request Jun 21, 2015
@ZacSweers ZacSweers merged commit efc2141 into pockethub:master Jun 21, 2015
@hidroh
Copy link
Copy Markdown
Contributor

hidroh commented Jun 21, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restructure project hierarchy to be a proper gradle project Roadmap: Gradle or Maven?

3 participants