Retain parameter field initializers in ctors (AssemblyScript#757)

Author: dcodeIO

src/compiler.ts

@@ -8935,40 +8935,36 @@ export class Compiler extends DiagnosticEmitter {
       let field = <Field>member; assert(!field.isAny(CommonFlags.CONST));
       let fieldType = field.type;
       let nativeFieldType = fieldType.toNativeType();
-      let initializerNode = field.prototype.initializerNode;
+      let fieldPrototype = field.prototype;
+      let initializerNode = fieldPrototype.initializerNode;
+      let parameterIndex = fieldPrototype.parameterIndex;
+      let initExpr: ExpressionRef;
       if (initializerNode) { // use initializer
-        let initExpr = this.compileExpression(initializerNode, fieldType, // reports
+        initExpr = this.compileExpression(initializerNode, fieldType, // reports
           Constraints.CONV_IMPLICIT | Constraints.WILL_RETAIN
         );
         if (fieldType.isManaged && !this.skippedAutoreleases.has(initExpr)) {
           initExpr = this.makeRetain(initExpr);
         }
-        stmts.push(
-          module.store(fieldType.byteSize,
-            module.local_get(thisLocalIndex, nativeSizeType),
-            initExpr,
-            nativeFieldType,
-            field.memoryOffset
-          )
-        );
-      } else {
-        let parameterIndex = field.prototype.parameterIndex;
-        stmts.push(
-          module.store(fieldType.byteSize,
-            module.local_get(thisLocalIndex, nativeSizeType),
-            parameterIndex >= 0 // initialized via parameter (here: a local)
-              ? module.local_get(
-                  isInline
-                    ? assert(flow.lookupLocal(field.name)).index
-                    : 1 + parameterIndex, // this is local 0
-                  nativeFieldType
-                )
-              : fieldType.toNativeZero(module),
-            nativeFieldType,
-            field.memoryOffset
-          )
+      } else if (parameterIndex >= 0) { // initialized via parameter (here: a local)
+        initExpr = module.local_get(
+          isInline
+            ? assert(flow.lookupLocal(field.name)).index
+            : 1 + parameterIndex, // this is local 0
+          nativeFieldType
         );
+        if (fieldType.isManaged) initExpr = this.makeRetain(initExpr);
+      } else { // initialize with zero
+        initExpr = fieldType.toNativeZero(module);
       }
+      stmts.push(
+        module.store(fieldType.byteSize,
+          module.local_get(thisLocalIndex, nativeSizeType),
+          initExpr,
+          nativeFieldType,
+          field.memoryOffset
+        )
+      );
     }
     return stmts;
   }