fix(epignosis/openlibrary): lowercase limit param (Solr ignores uppercase)#216
Merged
forkwright merged 1 commit intomainfrom Apr 22, 2026
Merged
fix(epignosis/openlibrary): lowercase limit param (Solr ignores uppercase)#216forkwright merged 1 commit intomainfrom
limit param (Solr ignores uppercase)#216forkwright merged 1 commit intomainfrom
Conversation
…ercase Open Library's Solr backend treats query parameter names as case-sensitive; "LIMIT" is silently dropped and the server returns its default page size instead of the requested 10. Silently over-fetching on every call. Surfaced by the #210 ebook-metadata research report (/tmp/research-harmonia-210-ebook-metadata.md).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Open Library's Solr backend treats query parameter names as case-sensitive. The existing code at
crates/epignosis/src/providers/openlibrary.rs:65passed"LIMIT"(uppercase); Solr silently drops unknown parameters and returns its default page size instead of the requested 10. Everysearch()call was over-fetching.Finding source
Research report for issue #210 at
/tmp/research-harmonia-210-ebook-metadata.mdcalled this out as a real pre-existing bug worth fixing inline during the #210 expansion arc.Test plan
Related: #210