feat(akroasis-core): Symphonia decode pipeline#37
Merged
forkwright merged 2 commits intomainfrom Mar 11, 2026
Merged
Conversation
added 2 commits
March 11, 2026 22:34
- SymphoniaDecoder: packet-by-packet streaming decode, all AudioBufferRef sample formats normalized to interleaved f64 [-1.0, 1.0] - ResetRequired handled for chained OGG streams; DecodeError frames logged and skipped to preserve playback continuity - Gapless metadata extracted from symphonia codec params (delay/padding); Vorbis pre-skip hardcoded to 3456 per symphonia issue #418 - probe.rs: open_decoder and probe_codec via MediaSourceStream + Hint - metadata.rs: read_gapless_info (codec-routed, lossless short-circuits), read_track_metadata (lofty; ReplayGain + R128 tag parsing), TrackMetadata type - AudioDecoder trait changed to Pin<Box<dyn Future>> returns for dyn compat - DecodedFrame.samples changed to Box<[f64]> - 52 tests pass (cargo check, test, clippy -D warnings all green)
forkwright
force-pushed
the
p1-02/decode
branch
from
af130ba to
da43efb
Compare
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decode/symphonia.rs): packet-by-packet streaming decode via symphonia 0.5. Handles allAudioBufferRefsample formats (U8–F64) normalized to interleavedf64 [-1.0, 1.0].ResetRequirederrors restart the decoder for chained OGG streams;DecodeErrorframes are logged viatracingand skipped to preserve playback continuity. Gapless metadata read from symphonia codec params (delay/padding); Vorbis pre-skip hardcoded to 3456 per symphonia issue #418.decode/probe.rs):open_decoderandprobe_codecopen files viaMediaSourceStream+ extensionHint, route everything symphonia can probe toSymphoniaDecoder.decode/metadata.rs):read_gapless_info(codec-routed; lossless formats short-circuit toNone),read_track_metadata(lofty 0.22; parses ReplayGain and R128 string tags),TrackMetadatastruct.AudioDecodermethodsnext_frame/seeknow returnPin<Box<dyn Future>>for dyn-compatibility (Box<dyn AudioDecoder>required byopen_decoder).DecodedFrame.sampleschanged fromVec<f64>toBox<[f64]>.Test plan
cargo check— cleancargo test— 52 tests pass (17 new decode tests added)cargo clippy -- -D warnings— clean