feat(desktop): now playing with playback controls and queue (P3-11)#84
Merged
forkwright merged 2 commits intomainfrom Mar 14, 2026
Merged
feat(desktop): now playing with playback controls and queue (P3-11)#84forkwright merged 2 commits intomainfrom
forkwright merged 2 commits intomainfrom
Conversation
Contributor
|
Consider splitting into smaller PRs for easier review. Not a blocker, just a signal. |
e7e4f4b to
c1c48e4
Compare
added 2 commits
March 14, 2026 02:03
…d (P3-11) Add double-click-to-play and per-row play/add-to-queue buttons to TracksPage. Add play-album, shuffle-album, and add-to-queue overlays to AlbumsPage. Fix cargo fmt style in dsp and playback modules; remove unused stopPlayback binding from TransportControls; add listTracksForAlbum to api client.
c1c48e4 to
2ab1c9d
Compare
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DesktopQueuewith shuffle/repeat, stream download via HTTP, akroasis-coreEngineintegration, 18 IPC commandsfeatures/now-playing/TypeScript feature: Zustand store, hooks (usePlaybackState,useQueue,useSignalPath,useKeyboardShortcuts), components (NowPlayingBar,TransportControls,ProgressBar,VolumeControl,TrackInfo,QualityIndicator,ExpandedView), pages (QueuePage,SignalPathPage)TracksPage; play-album/shuffle-album/add-to-queue overlays onAlbumsPage/queueand/signal-pathroutes; keyboard shortcuts (Space, arrows, M, N, P, S, R)Blast radius
desktop/src-tauri/Cargo.toml— new deps: snafu, tracing, rand, akroasis-core, tokio sync/timedesktop/src-tauri/src/lib.rs— registers 18 new playback IPC commandsdesktop/src-tauri/src/playback/— new module:mod.rs,queue.rs,stream.rs,signal_path.rs,commands.rsdesktop/src/types/playback.ts— new shared TS typesdesktop/src/features/now-playing/— new feature directory (store, hooks, components, pages)desktop/src/components/Layout.tsx— replaces placeholder with<NowPlayingBar />desktop/src/App.tsx— adds/queueand/signal-pathroutesdesktop/src/features/library/TracksPage.tsx— double-click-to-play, play/add-to-queue buttonsdesktop/src/features/library/AlbumsPage.tsx— album play/shuffle/add-to-queue overlaysdesktop/src/api/client.ts— addslistTracksForAlbumValidation gate
All gates pass:
cargo check— zero errorscargo clippy -- -D warnings— zero warningsnpm run lint(eslint) — zero errorsnpm run build(tsc + vite) — clean build, 382 KB bundleTest plan
npm run tauri dev/queueroute renders drag-to-reorder queue page/signal-pathroute renders signal path chainObservations
listTracksForAlbumcalls/api/music/release-groups/{id}/tracks; this endpoint is not yet in Mouseion. A follow-up backend PR is needed. Album play actions fail gracefully (empty tracks → no-op) until then.Enginerequiresunsafe impl Send + Sync for PlaybackEnginebecauseArc<Engine>cannot be proven Send automatically; Engine declares these traits explicitly viaunsafe implin the core crate.