fix: regression: save file compatibility #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 7ed2880 breaks compatibility of save files with previous versions. Restore compatibilty by adding manual padding to two of the structs, and also add a static_assert to the four structs which have commentary regarding save files to validate the size at compile time.
jodavies
force-pushed
the
fix-sav-regression
branch
from
6285548 to
6b4aec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 7ed2880 breaks compatibility of save files with previous versions. Restore compatibilty by adding manual padding to two of the structs, and also add a static_assert to the four structs which have commentary regarding save files to validate the size at compile time.
Adding the static asserts mean that the code doesn't compile for 32 bits; this means that sav files created by 32bit form are not compatible with 64bit form, and vice versa. I suppose we know this already.
I would like to keep the assertions; maybe it suffices to wrap them in
#if ( BITSINWORD == 64 )?