fix(connectors): handle no results case from Stripe API list endpoints

[laouji]

Fixes: ENG-1634

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request addresses potential runtime errors in the Stripe client by modifying three functions: GetAccounts, GetExternalAccounts, and GetPayments. The changes focus on gracefully handling scenarios where API calls return no results, introducing early return mechanisms to prevent index out of range panics. These modifications ensure that the functions can handle empty result sets consistently, returning appropriate values and maintaining the expected control flow even when no data is retrieved from the Stripe API.

Changes

File	Change Summary
internal/connectors/plugins/public/stripe/client/accounts.go	Added conditional check to return early if no accounts are found
internal/connectors/plugins/public/stripe/client/external_accounts.go	Added early return mechanism when no external accounts are retrieved
internal/connectors/plugins/public/stripe/client/payments.go	Introduced handling for scenarios with zero balance transactions

Assessment against linked issues

Objective	Addressed	Explanation
Resolve panic when no API results are returned [ENG-1634]	✅

Possibly related PRs

• fix(tools): fix connector template generation #271: Similar modifications to account and external account retrieval methods
• fix(atlar): fix payout creation and polling statuses #305: Conceptually related changes in handling empty result conditions

Suggested reviewers

• paul-nicolas

Poem

🐰 In the realm of Stripe's API dance,
No results shall cause a panic's trance
With early returns, we've fixed the flow
Graceful handling, now smooth and slow
A rabbit's code, both smart and light! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1dc8839 and 383f807.

📒 Files selected for processing (3)

• internal/connectors/plugins/public/stripe/client/accounts.go (1 hunks)
• internal/connectors/plugins/public/stripe/client/external_accounts.go (1 hunks)
• internal/connectors/plugins/public/stripe/client/payments.go (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.87%. Comparing base (1dc8839) to head (383f807).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...onnectors/plugins/public/stripe/client/accounts.go	0.00%	3 Missing ⚠️
.../plugins/public/stripe/client/external_accounts.go	0.00%	3 Missing ⚠️
...onnectors/plugins/public/stripe/client/payments.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   72.89%   72.87%   -0.03%     
==========================================
  Files         539      539              
  Lines       27300    27309       +9     
==========================================
  Hits        19901    19901              
- Misses       6324     6333       +9     
  Partials     1075     1075              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.