chore(e2e): adapt to cloud provider

[Dav-14]

No description provided.

[coderabbitai]

Walkthrough

This update removes an unused test helper, refines the process for generating documentation by clearing and recreating the docs directory, and simplifies end-to-end test configurations. The tests now rely on the current organization context instead of requiring explicit organization ID handling, streamlining provider and resource configuration across multiple test files.

Changes

Files/Group	Change Summary
internal/resources/main_test.go	Deleted file containing only a commented-out test helper function.
main.go	Added go:generate directives to clear and recreate docs before regenerating documentation.
tests/e2e/main_test.go	Removed organization ID env var and usage; refactored newStack to use only region name and current org context.
tests/e2e/ledger_test.go, tests/e2e/noop_test.go, tests/e2e/webhooks_test.go	Updated test setup to remove explicit organization ID usage; provider now uses current organization data source.
tests/e2e/stack_test.go	Changed newStack call to use only region name argument.

Sequence Diagram(s)

sequenceDiagram
    participant TestRunner
    participant Terraform
    participant Provider
    participant DataSource

    TestRunner->>Terraform: Initialize test configuration (region only)
    Terraform->>DataSource: Query current organization
    DataSource-->>Terraform: Return organization ID
    Terraform->>Provider: Configure provider with current org ID
    Provider-->>Terraform: Provider ready
    TestRunner->>Terraform: Execute resource tests

Loading

Poem

In the warren, code is neat,
Old helpers gone, now obsolete.
Docs are swept, then born anew,
Tests now simpler, streamlined too.
No more IDs to pass around,
Just current context—safe and sound!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between df3a796 and 9c211da.

⛔ Files ignored due to path filters (2)

• go.mod is excluded by !**/*.mod
• go.sum is excluded by !**/*.sum, !**/*.sum

📒 Files selected for processing (7)

• internal/resources/main_test.go (0 hunks)
• main.go (1 hunks)
• tests/e2e/ledger_test.go (2 hunks)
• tests/e2e/main_test.go (4 hunks)
• tests/e2e/noop_test.go (1 hunks)
• tests/e2e/stack_test.go (1 hunks)
• tests/e2e/webhooks_test.go (2 hunks)

💤 Files with no reviewable changes (1)

• internal/resources/main_test.go

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Tests (Integration)
• GitHub Check: Tests (E2E)
• GitHub Check: Tests (Unit)
• GitHub Check: Dirty (Pre-commit)

🔇 Additional comments (14)

main.go (1)

5-6: LGTM! Clean documentation generation approach.

The addition of rm -rf docs followed by mkdir docs ensures that documentation generation starts with a clean slate, preventing potential artifacts from previous runs. This is a good practice for consistent and reliable documentation generation.

tests/e2e/stack_test.go (1)

27-27: Good simplification - removing explicit organization ID handling.

The change to remove the OrganizationId parameter from newStack aligns well with the broader refactor to rely on the current organization context instead of explicit ID passing. This simplifies test configuration and makes it more maintainable.

tests/e2e/noop_test.go (2)

26-26: Consistent with the refactor pattern - removing explicit organization ID.

The removal of OrganizationId from the newStack call is consistent with the broader simplification effort across all e2e test files.

---

30-30: Good use of current organization data source.

Switching from formancecloud_stack.default.organization_id to data.formancecloud_current_organization.default.id standardizes the approach across tests and leverages the current organization context more effectively.

tests/e2e/ledger_test.go (2)

29-29: Consistent refactor application across test steps.

Both newStack calls in the test steps have been updated consistently to remove the OrganizationId parameter, maintaining coherent behavior across the test progression.

Also applies to: 58-58

---

33-33: Standardized organization ID referencing.

Both provider configurations now consistently use data.formancecloud_current_organization.default.id, which standardizes how organization context is accessed across test steps.

Also applies to: 62-62

tests/e2e/webhooks_test.go (2)

30-30: Final consistent application of the refactor pattern.

Both test steps have been updated to remove the OrganizationId parameter from newStack calls, completing the consistent refactor pattern across all e2e test files.

Also applies to: 68-68

---

39-39: Completed standardization of organization ID handling.

The provider configurations now consistently use the current organization data source, completing the migration away from explicit organization ID references across all test files.

Also applies to: 77-77

tests/e2e/main_test.go (6)

28-30: LGTM! Clean variable declarations.

The provider function variables are properly declared and align with the simplified test setup.

---

35-35: Function call correctly updated to match new signature.

The call to newStack now properly passes only the RegionName parameter, consistent with the updated function signature.

---

52-53: Environment validation correctly updated.

The removal of OrganizationId from the required environment variables is consistent with the shift to using the current organization context instead of explicit organization IDs.

---

99-99: Function signature simplified correctly.

The removal of the organizationId parameter from newStack aligns with the broader simplification to use current organization context instead of explicit IDs.

---

101-101: Data source change simplifies organization handling.

The switch from formancecloud_organizations to formancecloud_current_organization eliminates the need for explicit organization ID management and leverages the current context. This is a clean architectural improvement.

---

90-90: Verify the CloudSDK API change.

The change from cloudpkg.NewSDK to cloudpkg.NewCloudSDK() suggests an API update. Ensure this change is compatible and the new function provides the same functionality.

#!/bin/bash
# Description: Verify that NewCloudSDK function exists and is properly implemented
# Expected: Function should exist and be compatible with the provider initialization

# Search for the NewCloudSDK function definition
ast-grep --pattern 'func NewCloudSDK() $$$'

# Also search for any usage patterns to understand the API
rg -A 5 "NewCloudSDK"

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate Unit Tests

• Create PR with Unit Tests
• Post Copyable Unit Tests in Comment
• Commit Unit Tests in branch chore/adapt_e2e_to_cloud_provider

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.90%. Comparing base (df3a796) to head (9c211da).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   56.76%   56.90%   +0.13%     
==========================================
  Files          19       19              
  Lines        1448     1448              
==========================================
+ Hits          822      824       +2     
+ Misses        519      518       -1     
+ Partials      107      106       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.